Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Side by Side Diff: cc/output/output_surface.cc

Issue 23796002: cc: Implement deadine scheduling disabled by default (Closed) Base URL: http://git.chromium.org/chromium/src.git@schedReadback4
Patch Set: Fix context lost race conditions Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/output/output_surface.h" 5 #include "cc/output/output_surface.h"
6 6
7 #include <algorithm>
7 #include <set> 8 #include <set>
8 #include <string> 9 #include <string>
9 #include <vector> 10 #include <vector>
10 11
11 #include "base/bind.h" 12 #include "base/bind.h"
12 #include "base/debug/trace_event.h" 13 #include "base/debug/trace_event.h"
13 #include "base/logging.h" 14 #include "base/logging.h"
14 #include "base/message_loop/message_loop.h" 15 #include "base/message_loop/message_loop.h"
15 #include "base/strings/string_split.h" 16 #include "base/strings/string_split.h"
16 #include "base/strings/string_util.h" 17 #include "base/strings/string_util.h"
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 skipped_begin_frame_args_ = args; 154 skipped_begin_frame_args_ = args;
154 } else { 155 } else {
155 begin_frame_pending_ = true; 156 begin_frame_pending_ = true;
156 client_->BeginFrame(args); 157 client_->BeginFrame(args);
157 // args might be an alias for skipped_begin_frame_args_. 158 // args might be an alias for skipped_begin_frame_args_.
158 // Do not reset it before calling BeginFrame! 159 // Do not reset it before calling BeginFrame!
159 skipped_begin_frame_args_ = BeginFrameArgs(); 160 skipped_begin_frame_args_ = BeginFrameArgs();
160 } 161 }
161 } 162 }
162 163
163 base::TimeDelta OutputSurface::AlternateRetroactiveBeginFramePeriod() { 164 base::TimeTicks OutputSurface::RetroactiveBeginFrameDeadline() {
164 return BeginFrameArgs::DefaultRetroactiveBeginFramePeriod(); 165 // TODO(brianderson): Remove the alternative deadline once we have better
166 // deadline estimations.
167 base::TimeTicks alternative_deadline =
168 skipped_begin_frame_args_.frame_time +
169 BeginFrameArgs::DefaultRetroactiveBeginFramePeriod();
170 return std::max(skipped_begin_frame_args_.deadline, alternative_deadline);
165 } 171 }
166 172
167 void OutputSurface::PostCheckForRetroactiveBeginFrame() { 173 void OutputSurface::PostCheckForRetroactiveBeginFrame() {
168 if (!skipped_begin_frame_args_.IsValid() || 174 if (!skipped_begin_frame_args_.IsValid() ||
169 check_for_retroactive_begin_frame_pending_) 175 check_for_retroactive_begin_frame_pending_)
170 return; 176 return;
171 177
172 base::MessageLoop::current()->PostTask( 178 base::MessageLoop::current()->PostTask(
173 FROM_HERE, 179 FROM_HERE,
174 base::Bind(&OutputSurface::CheckForRetroactiveBeginFrame, 180 base::Bind(&OutputSurface::CheckForRetroactiveBeginFrame,
175 weak_ptr_factory_.GetWeakPtr())); 181 weak_ptr_factory_.GetWeakPtr()));
176 check_for_retroactive_begin_frame_pending_ = true; 182 check_for_retroactive_begin_frame_pending_ = true;
177 } 183 }
178 184
179 void OutputSurface::CheckForRetroactiveBeginFrame() { 185 void OutputSurface::CheckForRetroactiveBeginFrame() {
180 TRACE_EVENT0("cc", "OutputSurface::CheckForRetroactiveBeginFrame"); 186 TRACE_EVENT0("cc", "OutputSurface::CheckForRetroactiveBeginFrame");
181 check_for_retroactive_begin_frame_pending_ = false; 187 check_for_retroactive_begin_frame_pending_ = false;
182 base::TimeTicks now = base::TimeTicks::Now(); 188 if (base::TimeTicks::Now() < RetroactiveBeginFrameDeadline())
183 // TODO(brianderson): Remove the alternative deadline once we have better
184 // deadline estimations.
185 base::TimeTicks alternative_deadline =
186 skipped_begin_frame_args_.frame_time +
187 AlternateRetroactiveBeginFramePeriod();
188 if (now < skipped_begin_frame_args_.deadline ||
189 now < alternative_deadline) {
190 BeginFrame(skipped_begin_frame_args_); 189 BeginFrame(skipped_begin_frame_args_);
191 }
192 } 190 }
193 191
194 void OutputSurface::DidSwapBuffers() { 192 void OutputSurface::DidSwapBuffers() {
195 begin_frame_pending_ = false; 193 begin_frame_pending_ = false;
196 pending_swap_buffers_++; 194 pending_swap_buffers_++;
197 TRACE_EVENT1("cc", "OutputSurface::DidSwapBuffers", 195 TRACE_EVENT1("cc", "OutputSurface::DidSwapBuffers",
198 "pending_swap_buffers_", pending_swap_buffers_); 196 "pending_swap_buffers_", pending_swap_buffers_);
199 if (frame_rate_controller_) 197 if (frame_rate_controller_)
200 frame_rate_controller_->DidSwapBuffers(); 198 frame_rate_controller_->DidSwapBuffers();
201 PostCheckForRetroactiveBeginFrame(); 199 PostCheckForRetroactiveBeginFrame();
202 } 200 }
203 201
204 void OutputSurface::OnSwapBuffersComplete(const CompositorFrameAck* ack) { 202 void OutputSurface::OnSwapBuffersComplete(const CompositorFrameAck* ack) {
205 pending_swap_buffers_--; 203 pending_swap_buffers_--;
206 TRACE_EVENT1("cc", "OutputSurface::OnSwapBuffersComplete", 204 TRACE_EVENT1("cc", "OutputSurface::OnSwapBuffersComplete",
207 "pending_swap_buffers_", pending_swap_buffers_); 205 "pending_swap_buffers_", pending_swap_buffers_);
208 client_->OnSwapBuffersComplete(ack); 206 client_->OnSwapBuffersComplete(ack);
209 if (frame_rate_controller_) 207 if (frame_rate_controller_)
210 frame_rate_controller_->DidSwapBuffersComplete(); 208 frame_rate_controller_->DidSwapBuffersComplete();
211 PostCheckForRetroactiveBeginFrame(); 209 PostCheckForRetroactiveBeginFrame();
212 } 210 }
213 211
214 void OutputSurface::DidLoseOutputSurface() { 212 void OutputSurface::DidLoseOutputSurface() {
215 TRACE_EVENT0("cc", "OutputSurface::DidLoseOutputSurface"); 213 TRACE_EVENT0("cc", "OutputSurface::DidLoseOutputSurface");
216 begin_frame_pending_ = false; 214 begin_frame_pending_ = false;
217 pending_swap_buffers_ = 0; 215 pending_swap_buffers_ = 0;
216 skipped_begin_frame_args_ = BeginFrameArgs();
217 if (frame_rate_controller_)
218 frame_rate_controller_->SetActive(false);
218 client_->DidLoseOutputSurface(); 219 client_->DidLoseOutputSurface();
219 } 220 }
220 221
221 void OutputSurface::SetExternalStencilTest(bool enabled) { 222 void OutputSurface::SetExternalStencilTest(bool enabled) {
222 external_stencil_test_enabled_ = enabled; 223 external_stencil_test_enabled_ = enabled;
223 } 224 }
224 225
225 void OutputSurface::SetExternalDrawConstraints(const gfx::Transform& transform, 226 void OutputSurface::SetExternalDrawConstraints(const gfx::Transform& transform,
226 gfx::Rect viewport, 227 gfx::Rect viewport,
227 gfx::Rect clip, 228 gfx::Rect clip,
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
399 "discard_backbuffer", discard_backbuffer); 400 "discard_backbuffer", discard_backbuffer);
400 // Just ignore the memory manager when it says to set the limit to zero 401 // Just ignore the memory manager when it says to set the limit to zero
401 // bytes. This will happen when the memory manager thinks that the renderer 402 // bytes. This will happen when the memory manager thinks that the renderer
402 // is not visible (which the renderer knows better). 403 // is not visible (which the renderer knows better).
403 if (policy.bytes_limit_when_visible) 404 if (policy.bytes_limit_when_visible)
404 client_->SetMemoryPolicy(policy); 405 client_->SetMemoryPolicy(policy);
405 client_->SetDiscardBackBufferWhenNotVisible(discard_backbuffer); 406 client_->SetDiscardBackBufferWhenNotVisible(discard_backbuffer);
406 } 407 }
407 408
408 } // namespace cc 409 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698