Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5617)

Unified Diff: chrome/browser/extensions/api/chrome_extensions_api_client.cc

Issue 2379573008: Add SetImageData api to chrome.clipboard. (Closed)
Patch Set: Update idl for possible web alternative timeline. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/chrome_extensions_api_client.cc
diff --git a/chrome/browser/extensions/api/chrome_extensions_api_client.cc b/chrome/browser/extensions/api/chrome_extensions_api_client.cc
index d65c7b41f03bba7374b7879f714b53298c1789aa..d26560f589051d9feeb2a49a3cede0663aefb82d 100644
--- a/chrome/browser/extensions/api/chrome_extensions_api_client.cc
+++ b/chrome/browser/extensions/api/chrome_extensions_api_client.cc
@@ -36,6 +36,7 @@
#if defined(OS_CHROMEOS)
#include "chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.h"
+#include "chrome/browser/extensions/clipboard_extension_helper_chromeos.h"
#endif
#if BUILDFLAG(ENABLE_PRINTING)
@@ -49,7 +50,8 @@
namespace extensions {
-ChromeExtensionsAPIClient::ChromeExtensionsAPIClient() {}
+ChromeExtensionsAPIClient::ChromeExtensionsAPIClient() {
Devlin 2016/12/21 23:58:38 Why this change?
jennyz 2016/12/22 22:45:21 I thought you suggested me to move it to ChromeExt
Devlin 2016/12/27 17:08:00 Yes. But why do we need to put a newline here? I
jennyz 2016/12/29 05:16:03 Done.
+}
ChromeExtensionsAPIClient::~ChromeExtensionsAPIClient() {}
@@ -166,4 +168,17 @@ MetricsPrivateDelegate* ChromeExtensionsAPIClient::GetMetricsPrivateDelegate() {
return metrics_private_delegate_.get();
}
+#if defined(OS_CHROMEOS)
+void ChromeExtensionsAPIClient::SaveImageDataToClipboard(
+ const std::vector<char>& image_data,
+ api::clipboard::ImageType type,
+ const base::Closure& success_callback,
+ const base::Callback<void(const std::string&)>& error_callback) {
+ if (!clipboard_extension_helper_)
+ clipboard_extension_helper_.reset(new ClipboardExtensionHelper());
Devlin 2016/12/21 23:58:38 prefer MakeUnique
jennyz 2016/12/22 22:45:21 Done.
+ clipboard_extension_helper_->DecodeAndSaveImageData(
+ image_data, type, success_callback, error_callback);
+}
+#endif
+
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698