Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: extensions/browser/api/clipboard/clipboard_api.cc

Issue 2379573008: Add SetImageData api to chrome.clipboard. (Closed)
Patch Set: Address code review comments and add test cases. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/clipboard/clipboard_api.cc
diff --git a/extensions/browser/api/clipboard/clipboard_api.cc b/extensions/browser/api/clipboard/clipboard_api.cc
index 9b996e460181bf8a7ea8080ed474c0dab65c36b5..aba9d56b7894f3c64fe8c564a1b766f8e94bca9f 100644
--- a/extensions/browser/api/clipboard/clipboard_api.cc
+++ b/extensions/browser/api/clipboard/clipboard_api.cc
@@ -10,13 +10,11 @@
#include "base/memory/ptr_util.h"
#include "base/values.h"
#include "extensions/browser/event_router.h"
-#include "extensions/common/api/clipboard.h"
+#include "extensions/browser/extensions_browser_client.h"
#include "ui/base/clipboard/clipboard_monitor.h"
namespace extensions {
-namespace clipboard = api::clipboard;
-
static base::LazyInstance<BrowserContextKeyedAPIFactory<ClipboardAPI>>
g_factory = LAZY_INSTANCE_INITIALIZER;
@@ -47,4 +45,31 @@ void ClipboardAPI::OnClipboardDataChanged() {
}
}
+ClipboardSetImageDataFunction::~ClipboardSetImageDataFunction() {}
+
+ExtensionFunction::ResponseAction ClipboardSetImageDataFunction::Run() {
+ std::unique_ptr<clipboard::SetImageData::Params> params(
+ clipboard::SetImageData::Params::Create(*args_));
+ EXTENSION_FUNCTION_VALIDATE(params);
+ SaveImageData(params->image_data, params->type);
+ return RespondLater();
+}
+
+void ClipboardSetImageDataFunction::SaveImageData(
+ const std::vector<char>& image_data,
+ clipboard::ImageType type) {
+ ExtensionsBrowserClient::Get()->SaveImageDataToClipboard(
+ image_data, type,
+ base::Bind(&ClipboardSetImageDataFunction::OnSaveImageDataSuccess, this),
+ base::Bind(&ClipboardSetImageDataFunction::OnSaveImageDataError, this));
+}
+
+void ClipboardSetImageDataFunction::OnSaveImageDataSuccess() {
+ Respond(NoArguments());
+}
+
+void ClipboardSetImageDataFunction::OnSaveImageDataError() {
+ Respond(Error("Failed to save image data on clipboard"));
Devlin 2016/12/09 15:23:53 Do we want to indicate why? This isn't a very hel
jennyz 2016/12/14 01:15:36 Changed to accept an error string for detailed err
+}
+
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698