Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3457)

Unified Diff: chrome/browser/extensions/clipboard_extension_apitest_chromeos.cc

Issue 2379573008: Add SetImageData api to chrome.clipboard. (Closed)
Patch Set: Address code review comments and add test cases. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/clipboard_extension_apitest_chromeos.cc
diff --git a/chrome/browser/extensions/clipboard_extension_apitest_chromeos.cc b/chrome/browser/extensions/clipboard_extension_apitest_chromeos.cc
index 37fa8118e31b2bab20f0d8ca8c09f6f08a612aaa..71bce83f5a6e4c58af1409ff7846133b62584d07 100644
--- a/chrome/browser/extensions/clipboard_extension_apitest_chromeos.cc
+++ b/chrome/browser/extensions/clipboard_extension_apitest_chromeos.cc
@@ -17,3 +17,14 @@ IN_PROC_BROWSER_TEST_F(ClipboardExtensionApiTest, ClipboardDataChanged) {
<< message_;
ASSERT_TRUE(result_listener.WaitUntilSatisfied());
}
+
+IN_PROC_BROWSER_TEST_F(ClipboardExtensionApiTest, SetImageData) {
Devlin 2016/12/09 15:23:43 What's the reason this can't be a unittest?
jennyz 2016/12/14 01:15:35 I made ClipboardExtensionApiTest into a interactiv
Devlin 2016/12/16 02:26:15 If it can, let's make it a unit test. Unit tests
jennyz 2016/12/19 07:01:36 I am not familiar with writing unit test for exten
jennyz 2016/12/20 22:16:54 I took a look at converting it to a unit test, it
+ ASSERT_TRUE(StartEmbeddedTestServer());
+ ExtensionTestMessageListener test_listener("test success 3", false);
+ ExtensionTestMessageListener clipboard_change_listener(
+ "clipboard data changed 2", false);
+ ASSERT_TRUE(RunPlatformAppTest("clipboard/set_image_data"))
+ << message_;
+ ASSERT_TRUE(test_listener.WaitUntilSatisfied());
+ ASSERT_TRUE(clipboard_change_listener.WaitUntilSatisfied());
+}

Powered by Google App Engine
This is Rietveld 408576698