Add SetImageData api to chrome.clipboard.

extensions/common/api/_api_features.json

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This features file defines extension APIs implemented under src/extensions.
 // See chrome/common/extensions/api/_features.md to understand this file, as
 // well as feature.h, simple_feature.h, and base_feature_provider.h.
 //
 // Note that specifying "web_page", "blessed_web_page", or "all" as a context
 // type will require manually updating chrome/renderer/resources/dispatcher.cc.
@@ skipping 95 matching lines @@
       "chrome://md-settings/*",
       "chrome://settings/*",
       "chrome://settings-frame/*"
     ]
   }],
   "bluetoothSocket": {
     "dependencies": ["manifest:bluetooth"],
     "contexts": ["blessed_extension"]
   },
   "clipboard": {
-    "dependencies": ["permission:clipboard", "permission:clipboardRead"],
+    "dependencies": [
+    "permission:clipboard", "permission:clipboardReadWrite"

[Devlin, 2016/11/16 02:34:33]

This will disable this entire api for any existing extensions.

[jennyz, 2016/12/07 01:21:48]

This extension is a new one we added for Citrix remote app, so far they are the
only client who uses this API, no one has use this extension yet, so it should
be ok to make change now.

[Devlin, 2016/12/09 15:23:43]

Where is this whitelist enforced?

[jennyz, 2016/12/20 22:16:54]

No, I didn't enforce the whitelist. According to your comment later, I thought
it is OK for me to document the deprecation plan in the clipboard.idl, instead
of enforcing the whitelist.

[Devlin, 2016/12/22 16:07:49]

But this API isn't *only* used for the new function being added; it's also used
for the onClipboardDataChanged event.  Since the clipboard API is not restricted
to a whitelist, arbitrary apps and extensions can be relying on it.  If we add
an additional dependency, then any apps or extensions that don't specify that
dependency will be unable to use it, and will suddenly break in this chrome
version.  Additionally, there's no reason that an extension using the
onClipboardDataChanged event requires clipboardWrite, and no reason that setting
the image data to the clipboard requires clipboard read.  Right?

[jennyz, 2016/12/22 22:45:20]

Good point. I have removed clipboardReadWrite permission in the new patch. So
the app depending on onClipboardDataChanged will only need to require
clipboardRead permission.

[jennyz, 2016/12/22 23:31:40]

I read your comment again. After I removed the additional clipboardReadWrite
permission, if we need to make sure onClipboardDataChanged only requires
clipboardRead permission and SetImageData only requires clipboardWrite, then the
permission requirement is refined to API level instead of chrome.clipboard
namespace level, do I need to change _api_features_.json file to reconfigure the
permission dependency?

[Devlin, 2016/12/27 17:08:00]

Yes, if you want different permissions for different API methods, you need to
adjust the _api_features.json file.

[jennyz, 2016/12/29 05:16:03]

I made the change to adjust the permissions to API method level.

+    ],
     "contexts": ["blessed_extension"]       
   },
   "declarativeWebRequest": {
     "dependencies": ["permission:declarativeWebRequest"],
     "contexts": ["blessed_extension"]
   },
   "diagnostics": {
     "dependencies": ["permission:diagnostics"],
     "extension_types": ["platform_app"],
     "contexts": ["blessed_extension"]
@@ skipping 391 matching lines @@
   }, {
     "channel": "stable",
     "contexts": ["webui"],
     "matches": [
       "chrome://chrome-signin/*",
       "chrome://media-router/*",
       "chrome://oobe/*"
     ]
   }]
 }