build/config/BUILDCONFIG.gn - Issue 2379573003: [Windows] Pass "/MD" and variants outside the "runtime_library" target

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/BUILDCONFIG.gn

Issue 2379573003: [Windows] Pass "/MD" and variants outside the "runtime_library" target (Closed)

Patch Set: Fix another brainfart Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/BUILDCONFIG.gn

diff --git a/build/config/BUILDCONFIG.gn b/build/config/BUILDCONFIG.gn

index 071b54413c5ed59223585328bbf39aaabeacd89b..594a89c43b5f9b5649718f5ecfb77c479992ffe2 100644

--- a/build/config/BUILDCONFIG.gn

+++ b/build/config/BUILDCONFIG.gn

@@ -481,6 +481,7 @@ default_compiler_configs = [

]

if (is_win) {

default_compiler_configs += [

+ "//build/config/win:default_crt",

"//build/config/win:lean_and_mean",

"//build/config/win:nominmax",

"//build/config/win:unicode",

« no previous file with comments | « no previous file | build/config/win/BUILD.gn » ('j') | no next file with comments »