Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2379553002: Ntp: use android.support.annotation.Nullable (Closed)

Created:
4 years, 2 months ago by Michael van Ouwerkerk
Modified:
4 years, 2 months ago
Reviewers:
PEConn
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ntp: use android.support.annotation.Nullable BUG=None Committed: https://crrev.com/95d28ce52aadbe643988368aa231d027b82542f4 Cr-Commit-Position: refs/heads/master@{#421493}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/TitleUtil.java View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Michael van Ouwerkerk
Peter, could you take a look please?
4 years, 2 months ago (2016-09-28 10:17:06 UTC) #4
PEConn
On 2016/09/28 10:17:06, Michael van Ouwerkerk wrote: > Peter, could you take a look please? ...
4 years, 2 months ago (2016-09-28 10:20:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2379553002/1
4 years, 2 months ago (2016-09-28 10:54:42 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 10:59:25 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 11:01:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95d28ce52aadbe643988368aa231d027b82542f4
Cr-Commit-Position: refs/heads/master@{#421493}

Powered by Google App Engine
This is Rietveld 408576698