installer and some misc files: Change ScopedTempDir::path() to GetPath()

chrome/installer/util/delete_tree_work_item.cc

Index: chrome/installer/util/delete_tree_work_item.cc
diff --git a/chrome/installer/util/delete_tree_work_item.cc b/chrome/installer/util/delete_tree_work_item.cc
index 8fc5dadfed220c7193bab53f9d177c6374c96d90..1530a8bd499fd97ffa418245f35da71b62119922 100644
--- a/chrome/installer/util/delete_tree_work_item.cc
+++ b/chrome/installer/util/delete_tree_work_item.cc
@@ -39,14 +39,17 @@ void DeleteTreeWorkItem::RollbackImpl() {
 }
 
 base::FilePath DeleteTreeWorkItem::GetBackupPath() {
-  if (backup_path_.path().empty() &&
-      !backup_path_.CreateUniqueTempDirUnderPath(temp_path_)) {
-    PLOG(ERROR) << "Failed to get backup path in folder " << temp_path_.value();
-    return base::FilePath();
+  if (backup_path_.empty()) {
+    if (!backup_dir_.CreateUniqueTempDirUnderPath(temp_path_)) {
+      PLOG(ERROR) << "Failed to get backup path in folder "
+                  << temp_path_.value();
+      return base::FilePath();
+    }
+    backup_path_ = backup_dir_.GetPath();

[gab, 2016/09/28 16:31:59]

If we're going to have a local copy of this variable, then it might as well
contain the full path constructed by this method (i.e. do the Append() below
into it) and have this method return const base::FilePath& which its users will
be happy with (and will result in less copies overall, yay!)

[vabr (Chromium), 2016/09/29 09:11:03]

Done.

   }
 
-  DCHECK(!backup_path_.path().empty());
-  return backup_path_.path().Append(root_path_.BaseName());
+  DCHECK(!backup_path_.empty());
+  return backup_path_.Append(root_path_.BaseName());
 }
 
 bool DeleteTreeWorkItem::DeleteRoot() {