Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2379523002: DevTools: Remove recursion in ProfileTreeModel._calculateTotals (Closed)

Created:
4 years, 2 months ago by alph
Modified:
4 years, 2 months ago
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Remove recursion in ProfileTreeModel._calculateTotals V8 fails with recursion depth of 1000 under --ignition. BUG=650966 Committed: https://crrev.com/1a46e69915c9b8e7d715243a470b8a7975e74109 Cr-Commit-Position: refs/heads/master@{#421622}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-calculate-time.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ProfileTreeModel.js View 2 chunks +16 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
alph
4 years, 2 months ago (2016-09-28 08:32:14 UTC) #2
rmcilroy
Thanks for the fix! I don't have much knowledge here, but change LGTM.
4 years, 2 months ago (2016-09-28 15:15:25 UTC) #7
caseq
lgtm
4 years, 2 months ago (2016-09-28 19:21:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2379523002/1
4 years, 2 months ago (2016-09-28 20:10:12 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 20:15:49 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 20:19:40 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a46e69915c9b8e7d715243a470b8a7975e74109
Cr-Commit-Position: refs/heads/master@{#421622}

Powered by Google App Engine
This is Rietveld 408576698