Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 237943002: Makes windows repaint scrollbars when position changes (Closed)

Created:
6 years, 8 months ago by sky
Modified:
6 years, 8 months ago
Reviewers:
eseidel
CC:
blink-reviews, Julien - ping for review, leviw_travelin_and_unemployed
Visibility:
Public.

Description

Makes windows repaint scrollbars when position changes This is needed since arrows draw differently when thumb is at end points. BUG=358566 TEST=see bug R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171683

Patch Set 1 #

Patch Set 2 : update layout tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -37 lines) Patch
M LayoutTests/platform/win/compositing/overflow/scrolling-without-painting-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/platform/win/compositing/overflow/updating-scrolling-content-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/platform/win/fast/repaint/layout-state-only-positioned-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/win/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.txt View 1 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/platform/win/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.txt View 1 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/platform/win/fast/repaint/repaint-during-scroll-with-zoom-expected.txt View 1 1 chunk +2 lines, -6 lines 0 comments Download
M LayoutTests/platform/win/fast/repaint/scroll-inside-table-cell-expected.txt View 1 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/platform/win/fast/repaint/scroll-relative-table-inside-table-cell-expected.txt View 1 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/platform/win/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.txt View 1 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/platform/win/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.txt View 1 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/platform/win/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/platform/win/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/platform/win/virtual/softwarecompositing/overflow/scrolling-without-painting-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/platform/win/virtual/softwarecompositing/overflow/updating-scrolling-content-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/scroll/Scrollbar.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
sky
This file doesn't have much history, so I randomly picked you Eric. If you think ...
6 years, 8 months ago (2014-04-14 22:10:59 UTC) #1
eseidel
I can't imagine this is the right fix if this just regressed in M35. Could ...
6 years, 8 months ago (2014-04-14 22:21:46 UTC) #2
eseidel
If we're going to do this, we might as well delete this #define all together, ...
6 years, 8 months ago (2014-04-14 22:23:31 UTC) #3
eseidel
lgtm Scott tells me that Aura behavior changed in M35. So yeah, this makes total ...
6 years, 8 months ago (2014-04-14 22:27:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/237943002/1
6 years, 8 months ago (2014-04-14 22:27:25 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-14 22:53:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 8 months ago (2014-04-14 22:53:35 UTC) #7
sky
The CQ bit was checked by sky@chromium.org
6 years, 8 months ago (2014-04-15 00:33:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/237943002/1
6 years, 8 months ago (2014-04-15 00:33:21 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-15 01:02:40 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-15 01:02:41 UTC) #11
sky
Eric, I had to update some layout test expectations. Take another look?
6 years, 8 months ago (2014-04-15 18:30:21 UTC) #12
eseidel
lgtm Makes sense. It's sorta silly that blink isn't smart enough to only issue a ...
6 years, 8 months ago (2014-04-15 18:38:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/237943002/20001
6 years, 8 months ago (2014-04-15 18:38:37 UTC) #14
commit-bot: I haz the power
6 years, 8 months ago (2014-04-15 19:47:27 UTC) #15
Message was sent while issue was closed.
Change committed as 171683

Powered by Google App Engine
This is Rietveld 408576698