Propagate validation errors

Propagate validation errors from inner readbuffer when deserializing picture. Also allow null paints.

BUG=skia:5812
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2379383002

Committed: https://skia.googlesource.com/skia/+/d921dbb9b88327eef7b1fbd42e9d88bace4a65ff

[reed1, 2016-09-30 15:31:34]

Description was changed from

==========
allow null paints in deserialize

BUG=skia:
==========

to

==========
allow null paints in deserialize

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2379383002
==========

[reed1, 2016-09-30 15:31:48]

reed@google.com changed reviewers:
+ robertphillips@google.com

[reed1, 2016-09-30 15:31:53]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 15:32:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-09-30 15:36:45]

Description was changed from

==========
allow null paints in deserialize

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2379383002
==========

to

==========
allow null paints in deserialize

BUG=skia:5812
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2379383002
==========

[reed1, 2016-09-30 15:36:51]

The CQ bit was unchecked by reed@google.com

[reed1, 2016-09-30 15:36:57]

added bug

[reed1, 2016-09-30 15:56:19]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 15:56:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-09-30 15:56:34]

updated test

[reed1, 2016-09-30 15:58:13]

Description was changed from

==========
allow null paints in deserialize

BUG=skia:5812
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2379383002
==========

to

==========
Propagate validation errors from inner readbuffer when deserializing picture.
Also allow null paints.

BUG=skia:5812
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2379383002
==========

[robertphillips, 2016-09-30 15:59:17]

lgtm

https://codereview.chromium.org/2379383002/diff/20002/src/core/SkPicturePlayb...
File src/core/SkPicturePlayback.cpp (right):

https://codereview.chromium.org/2379383002/diff/20002/src/core/SkPicturePlayb...
src/core/SkPicturePlayback.cpp:118: // need to propagate invalid state to the
parent reader
buffer->validate(reader->isValid()); ?

[reed1, 2016-09-30 16:02:48]

The CQ bit was unchecked by reed@google.com

[reed1, 2016-09-30 16:04:13]

https://codereview.chromium.org/2379383002/diff/20002/src/core/SkPicturePlayb...
File src/core/SkPicturePlayback.cpp (right):

https://codereview.chromium.org/2379383002/diff/20002/src/core/SkPicturePlayb...
src/core/SkPicturePlayback.cpp:118: // need to propagate invalid state to the
parent reader
On 2016/09/30 15:59:16, robertphillips wrote:
> buffer->validate(reader->isValid()); ?

Done.

[reed1, 2016-09-30 16:06:14]

The CQ bit was checked by reed@google.com

[reed1, 2016-09-30 16:06:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2379383002/#ps70001
(title: "check for null buffer")

[commit-bot: I haz the power, 2016-09-30 16:06:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 16:27:21]

Description was changed from

==========
Propagate validation errors from inner readbuffer when deserializing picture.
Also allow null paints.

BUG=skia:5812
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2379383002
==========

to

==========
Propagate validation errors from inner readbuffer when deserializing picture.
Also allow null paints.

BUG=skia:5812
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2379383002

Committed:
https://skia.googlesource.com/skia/+/d921dbb9b88327eef7b1fbd42e9d88bace4a65ff
==========

[commit-bot: I haz the power, 2016-09-30 16:27:23]

Committed patchset #5 (id:70001) as
https://skia.googlesource.com/skia/+/d921dbb9b88327eef7b1fbd42e9d88bace4a65ff