Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 2379363003: [ARC] Add "(beta)" string to Play Store until we decide to take it off. (Closed)

Created:
4 years, 2 months ago by xdai1
Modified:
4 years, 2 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, Matt Giuca
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ARC] Add "(beta)" string to Play Store until we decide to take it off. - Add (beta) at the end of header of chrome://settings section that says "Google Play Store" - Add (beta) to Play Store icon title in launcher BUG=644576 Committed: https://crrev.com/06053d46706d6e95669e8facbf96ddbfbc9a3304 Cr-Commit-Position: refs/heads/master@{#422272}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc View 3 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
xdai1
xiyuan@, could you help review this CL please? It targets M55 and later and did ...
4 years, 2 months ago (2016-09-30 21:35:08 UTC) #2
xiyuan
lgtm
4 years, 2 months ago (2016-09-30 22:24:38 UTC) #3
xdai1
On 2016/09/30 22:24:38, xiyuan wrote: > lgtm Thanks for the review!
4 years, 2 months ago (2016-09-30 22:35:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2379363003/1
4 years, 2 months ago (2016-09-30 22:36:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-01 02:00:50 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-01 02:03:48 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06053d46706d6e95669e8facbf96ddbfbc9a3304
Cr-Commit-Position: refs/heads/master@{#422272}

Powered by Google App Engine
This is Rietveld 408576698