[Offline pages] Applying StoreState to track RequestQueueStore state

[Offline pages] Applying StoreState to track RequestQueueStore state

BUG=645522
Committed: https://crrev.com/53a9dfb296541463919a998fe30f2756cec2f0d1
Cr-Commit-Position: refs/heads/master@{#422317}

[fgorski, 2016-09-30 17:54:36]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 17:55:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fgorski, 2016-09-30 18:09:04]

fgorski@chromium.org changed reviewers:
+ petewil@chromium.org

[fgorski, 2016-09-30 18:09:04]

PTAL

[Pete Williamson, 2016-09-30 18:34:14]

LGTM, one naming nit.

https://codereview.chromium.org/2379353003/diff/1/components/offline_pages/ba...
File components/offline_pages/background/request_queue_store_sql.cc (right):

https://codereview.chromium.org/2379353003/diff/1/components/offline_pages/ba...
components/offline_pages/background/request_queue_store_sql.cc:414: const
base::Callback<void(StoreState)>& callback) {
Should we have a more descriptive name for this type?

Maybe keep using the name reset callback, but typedef it to
Callback<void(StoreState)>

[commit-bot: I haz the power, 2016-09-30 18:45:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 18:45:45]

Dry run: This issue passed the CQ dry run.

[fgorski, 2016-09-30 22:51:03]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2016-09-30 22:51:04]

The patchset sent to the CQ was uploaded after l-g-t-m from petewil@chromium.org
Link to the patchset: https://codereview.chromium.org/2379353003/#ps20001
(title: "Addressing feedback")

[fgorski, 2016-09-30 22:51:23]

Addressed

https://codereview.chromium.org/2379353003/diff/1/components/offline_pages/ba...
File components/offline_pages/background/request_queue_store_sql.cc (right):

https://codereview.chromium.org/2379353003/diff/1/components/offline_pages/ba...
components/offline_pages/background/request_queue_store_sql.cc:414: const
base::Callback<void(StoreState)>& callback) {
On 2016/09/30 18:34:14, Pete Williamson wrote:
> Should we have a more descriptive name for this type?
> 
> Maybe keep using the name reset callback, but typedef it to
> Callback<void(StoreState)>

Done.

[commit-bot: I haz the power, 2016-09-30 22:51:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 00:17:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 00:17:50]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fgorski, 2016-10-01 14:39:50]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2016-10-01 14:39:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 15:02:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-01 15:04:33]

Description was changed from

==========
[Offline pages] Applying StoreState to track RequestQueueStore state

BUG=645522
==========

to

==========
[Offline pages] Applying StoreState to track RequestQueueStore state

BUG=645522

Committed: https://crrev.com/53a9dfb296541463919a998fe30f2756cec2f0d1
Cr-Commit-Position: refs/heads/master@{#422317}
==========

[commit-bot: I haz the power, 2016-10-01 15:04:34]

Patchset 2 (id:??) landed as
https://crrev.com/53a9dfb296541463919a998fe30f2756cec2f0d1
Cr-Commit-Position: refs/heads/master@{#422317}