third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp - Issue 2379313002: Fix 'noopener' targeting and return value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

Issue 2379313002: Fix 'noopener' targeting and return value. (Closed)

Patch Set: Rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/rel-noopener/window-open.html ('k') | third_party/WebKit/Source/core/page/CreateWindow.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

index 176a6376689567713d4f45fe2c10e2f45e7a6160..2288a3c237461e3f882fcdcf57b08f6a97e2ce01 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

@@ -259,8 +259,10 @@ void V8Window::openMethodCustom(

DOMWindow* openedWindow = toLocalDOMWindow(impl)->open(

urlString, frameName, windowFeaturesString,

currentDOMWindow(info.GetIsolate()), enteredDOMWindow(info.GetIsolate()));

- if (!openedWindow)

+ if (!openedWindow) {

+ v8SetReturnValueNull(info);

return;

+ }

v8SetReturnValueFast(info, openedWindow, impl);

}