third_party/WebKit/LayoutTests/fast/html/marquee-without-frame-no-crash.html - Issue 2379313002: Fix 'noopener' targeting and return value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/html/marquee-without-frame-no-crash.html

Issue 2379313002: Fix 'noopener' targeting and return value. (Closed)

Patch Set: Rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/frames/sandboxed-iframe-navigation-top-by-name-denied.html ('k') | third_party/WebKit/LayoutTests/fast/html/marquee-without-frame-no-crash-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/html/marquee-without-frame-no-crash.html

diff --git a/third_party/WebKit/LayoutTests/fast/html/marquee-without-frame-no-crash.html b/third_party/WebKit/LayoutTests/fast/html/marquee-without-frame-no-crash.html

index 11f9386249e7bfd4c0e8f28343f0b351ca83371c..0f66084f5466b7b8f10ee2bb2dd16a11c2165e14 100644

--- a/third_party/WebKit/LayoutTests/fast/html/marquee-without-frame-no-crash.html

+++ b/third_party/WebKit/LayoutTests/fast/html/marquee-without-frame-no-crash.html

@@ -2,7 +2,7 @@

foo

function handler() {

- shouldBeUndefined(window.open("foo", "bar"));

+ shouldBeNull('window.open("foo", "bar")');

}

</script>