third_party/WebKit/LayoutTests/fast/events/popup-blocking-timers4.html - Issue 2379313002: Fix 'noopener' targeting and return value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/events/popup-blocking-timers4.html

Issue 2379313002: Fix 'noopener' targeting and return value. (Closed)

Patch Set: Rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/popup-blocking-timers3-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/events/popup-blocking-timers4-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/events/popup-blocking-timers4.html

diff --git a/third_party/WebKit/LayoutTests/fast/events/popup-blocking-timers4.html b/third_party/WebKit/LayoutTests/fast/events/popup-blocking-timers4.html

index a4a4332b0be9bf5e153789ee7472a113a18468cf..0c5f8d502bf73250199453c52911b1317b1d8a36 100644

--- a/third_party/WebKit/LayoutTests/fast/events/popup-blocking-timers4.html

+++ b/third_party/WebKit/LayoutTests/fast/events/popup-blocking-timers4.html

@@ -17,7 +17,7 @@

newWindow = window.open("about:blank");

self.focus();

debug("Test calling window.open() in a nested call to setTimeout(). A popup should not be allowed.")

- shouldBeUndefined("newWindow");

+ shouldBeNull("newWindow");

if (window.testRunner)

testRunner.notifyDone();

}, 0);