third_party/WebKit/LayoutTests/fast/events/popup-blocked-from-wrong-event.html - Issue 2379313002: Fix 'noopener' targeting and return value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/events/popup-blocked-from-wrong-event.html

Issue 2379313002: Fix 'noopener' targeting and return value. (Closed)

Patch Set: Rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/popup-blocked-from-untrusted-click-event-on-anchor-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/events/popup-blocked-from-wrong-event-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/events/popup-blocked-from-wrong-event.html

diff --git a/third_party/WebKit/LayoutTests/fast/events/popup-blocked-from-wrong-event.html b/third_party/WebKit/LayoutTests/fast/events/popup-blocked-from-wrong-event.html

index d4210d411634878a971655f41597c9e4f1a461b9..4218ec7d5bc4ced3bee80c720b86d44fe3393f45 100644

--- a/third_party/WebKit/LayoutTests/fast/events/popup-blocked-from-wrong-event.html

+++ b/third_party/WebKit/LayoutTests/fast/events/popup-blocked-from-wrong-event.html

@@ -38,7 +38,7 @@

mouseup.initMouseEvent("mouseup", true, true, window, 0, 0, 0, 0, 0, false, false, false, false, 0, null);

obj.dispatchEvent(mouseup);

// ... and we should not be able to open a new popup.

- shouldBeUndefined("window.open('about:blank')");

+ shouldBeNull("window.open('about:blank')");

finishJSTest();

}

</script>