third_party/WebKit/LayoutTests/http/tests/security/rel-noopener/window-open.html - Issue 2379313002: Fix 'noopener' targeting and return value.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/security/rel-noopener/window-open.html

Issue 2379313002: Fix 'noopener' targeting and return value. (Closed)

Patch Set: Rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/html/marquee-without-frame-no-crash-expected.txt ('k') | third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="/resources/testharness.js"></script>

	3 <script src="/resources/testharnessreport.js"></script>

	4 <script>

	5 if (window.testRunner)

	6 testRunner.setCanOpenWindows();

	7

	8 var windowsInThisProcess = 1; // This window counts.

	9

	10 test(t => {

	11 var w = window.open("", "", "noopener");

	12 assert_equals(w, null);

	13 if (window.testRunner)

	14 assert_equals(testRunner.windowCount(), windowsInThisProcess, "Shoul d have opened a window in a new process.");

	15 }, "window.open returns 'null' when 'noopener' present.");

	16

	17 test(t => {

	18 var w1 = window.open("", "windowname1", "noopener");

	19 if (window.testRunner)

	20 assert_equals(testRunner.windowCount(), windowsInThisProcess, "Shoul d have opened a window in a new process.");

	21 var w2 = window.open("", "windowname1");

	22 if (window.testRunner)

	23 assert_equals(testRunner.windowCount(), ++windowsInThisProcess, "Sho uld have opened a window in this process.");

	24 assert_equals(w1, null);

	25 assert_not_equals(w2, null);

	26 }, "Opening a named window as noopener, then normally should work.");

	27

	28 test(t => {

	29 var w1 = window.open("", "windowname2");

	30 if (window.testRunner)

	31 assert_equals(testRunner.windowCount(), ++windowsInThisProcess, "Sho uld have opened a window in this process.");

	32 var w2 = window.open("", "windowname2", "noopener");

	33 if (window.testRunner)

	34 assert_equals(testRunner.windowCount(), windowsInThisProcess, "Shoul d have opened a window a new process.");

	35 assert_not_equals(w1, null);

	36 assert_equals(w2, null);

	37 }, "Opening a named window normally, then as noopener should work.");

	38 </script>

OLD	NEW