third_party/WebKit/LayoutTests/fast/events/popup-blocked-from-different-frames.html - Issue 2379313002: Fix 'noopener' targeting and return value.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/popup-blocked-from-different-frames.html

Issue 2379313002: Fix 'noopener' targeting and return value. (Closed)

Patch Set: Rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/test/data/click-noreferrer-links.html ('k') | third_party/WebKit/LayoutTests/fast/events/popup-blocked-from-different-frames-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../../resources/js-test.js"></script>	4 <script src="../../resources/js-test.js"></script>

5 <style>	5 <style>

6 iframe {	6 iframe {

7 position: absolute;	7 position: absolute;

8 width: 100%;	8 width: 100%;

9 height: 100%;	9 height: 100%;

10 left: 0;	10 left: 0;

(...skipping 16 matching lines...) Expand all Loading...
27 {	27 {

28 win = window.open("about:blank");	28 win = window.open("about:blank");

29 shouldBeNonNull("win");	29 shouldBeNonNull("win");

30 win.close();	30 win.close();

31 document.querySelector("iframe").setAttribute("class", "");	31 document.querySelector("iframe").setAttribute("class", "");

32 }	32 }

33	33

34 function clickHandler2()	34 function clickHandler2()

35 {	35 {

36 win = window.open("about:blank");	36 win = window.open("about:blank");

37 shouldBeUndefined("win");	37 shouldBeNull("win");

38 }	38 }

39	39

40 document.querySelector("#test").addEventListener("mousedown", clickH andler1);	40 document.querySelector("#test").addEventListener("mousedown", clickH andler1);

41 document.querySelector("iframe").contentDocument.body.addEventListen er("mouseup", clickHandler2);	41 document.querySelector("iframe").contentDocument.body.addEventListen er("mouseup", clickHandler2);

42	42

43	43

44 if (window.testRunner) {	44 if (window.testRunner) {

45 testRunner.dumpAsText();	45 testRunner.dumpAsText();

46 testRunner.setCanOpenWindows();	46 testRunner.setCanOpenWindows();

47 testRunner.setPopupBlockingEnabled(true);	47 testRunner.setPopupBlockingEnabled(true);

48 testRunner.setCloseRemainingWindowsWhenComplete(true);	48 testRunner.setCloseRemainingWindowsWhenComplete(true);

49	49

50 var button = document.querySelector("#test");	50 var button = document.querySelector("#test");

51	51

52 eventSender.mouseMoveTo(button.offsetLeft + button.offsetWidth / 2, button.offsetTop + button.offsetHeight / 2);	52 eventSender.mouseMoveTo(button.offsetLeft + button.offsetWidth / 2, button.offsetTop + button.offsetHeight / 2);

53 eventSender.mouseDown();	53 eventSender.mouseDown();

54 eventSender.mouseUp();	54 eventSender.mouseUp();

55 }	55 }

56 </script>	56 </script>

57 </body>	57 </body>

58 </html>	58 </html>

OLD	NEW