Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2379303003: media: Delete code checking for pre-JellyBean Android versions (Closed)

Created:
4 years, 2 months ago by watk
Modified:
4 years, 2 months ago
CC:
chromium-reviews, avayvod+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, mlamouri+watch-media_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Delete code checking for pre-JellyBean Android versions API level < 16 is not supported by Chrome, so we don't need to handle it. Committed: https://crrev.com/90d1a3f8f09011d2545ea84c0ce4301482d6afd9 Cr-Commit-Position: refs/heads/master@{#422554}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -98 lines) Patch
M chrome/browser/media/encrypted_media_browsertest.cc View 5 chunks +0 lines, -21 lines 0 comments Download
M content/browser/media/encrypted_media_browsertest.cc View 3 chunks +0 lines, -21 lines 0 comments Download
M content/browser/media/media_source_browsertest.cc View 4 chunks +0 lines, -28 lines 0 comments Download
M media/audio/android/audio_android_unittest.cc View 3 chunks +6 lines, -14 lines 1 comment Download
M media/audio/android/audio_manager_android.cc View 1 chunk +1 line, -6 lines 0 comments Download
M media/audio/android/audio_record_input.h View 1 chunk +0 lines, -3 lines 0 comments Download
M media/base/android/media_codec_util.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
watk
4 years, 2 months ago (2016-09-30 23:57:32 UTC) #4
liberato (no reviews please)
lgtm. https://codereview.chromium.org/2379303003/diff/20001/media/audio/android/audio_android_unittest.cc File media/audio/android/audio_android_unittest.cc (right): https://codereview.chromium.org/2379303003/diff/20001/media/audio/android/audio_android_unittest.cc#newcode972 media/audio/android/audio_android_unittest.cc:972: testing::Bool()); that's neat.
4 years, 2 months ago (2016-10-03 15:43:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2379303003/20001
4 years, 2 months ago (2016-10-03 18:59:05 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 2 months ago (2016-10-03 22:07:18 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 22:09:01 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90d1a3f8f09011d2545ea84c0ce4301482d6afd9
Cr-Commit-Position: refs/heads/master@{#422554}

Powered by Google App Engine
This is Rietveld 408576698