Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2379303002: Revert "[inspector] added inspector test runner [part 3-5]" (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
Reviewers:
kozy, Michael Hablich
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "[inspector] added inspector test runner [part 3-5]" Revert "[inspector] added inspector test runner [part 3]" This reverts commit f3f9f4448dfa533d768878245a9bdbb57b4d941b. Revert "[inspector] added inspector test runner [part 4]" This reverts commit 4a5f5d0991656a6aa45b0021a0f5ba6a7ceabe15. Revert "[inspector] added inspector test runner [part 5]" This reverts commit 9ddbdab195923fc87fae3587ae06c5c1c5ca6d79. Reverting this in order to revert parts 1-2 which block the roll: https://codereview.chromium.org/2379053003/ BUG=chromium:635948 TBR=kozyatinskiy@chromium.org, NOTRY=true Committed: https://crrev.com/ee0d69910be28e29ed0f2d1195f67a43f7921f9c Cr-Commit-Position: refs/heads/master@{#39908}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3919 lines) Patch
M test/inspector/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M test/inspector/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D test/inspector/console/let-const-with-api.js View 1 chunk +0 lines, -52 lines 0 comments Download
D test/inspector/console/let-const-with-api-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D test/inspector/console/memory-setter-in-strict-mode.js View 1 chunk +0 lines, -14 lines 0 comments Download
D test/inspector/console/memory-setter-in-strict-mode-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D test/inspector/cpu-profiler/console-profile.js View 1 chunk +0 lines, -59 lines 0 comments Download
D test/inspector/cpu-profiler/console-profile-end-parameterless-crash.js View 1 chunk +0 lines, -46 lines 0 comments Download
D test/inspector/cpu-profiler/console-profile-end-parameterless-crash-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D test/inspector/cpu-profiler/console-profile-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D test/inspector/cpu-profiler/enable-disable.js View 1 chunk +0 lines, -75 lines 0 comments Download
D test/inspector/cpu-profiler/enable-disable-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D test/inspector/cpu-profiler/record-cpu-profile.js View 1 chunk +0 lines, -48 lines 0 comments Download
D test/inspector/cpu-profiler/record-cpu-profile-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D test/inspector/cpu-profiler/stop-without-preceeding-start.js View 1 chunk +0 lines, -12 lines 0 comments Download
D test/inspector/cpu-profiler/stop-without-preceeding-start-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D test/inspector/debugger/access-obsolete-frame.js View 1 chunk +0 lines, -69 lines 0 comments Download
D test/inspector/debugger/access-obsolete-frame-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D test/inspector/debugger/call-frame-function-location.js View 1 chunk +0 lines, -25 lines 0 comments Download
D test/inspector/debugger/call-frame-function-location-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D test/inspector/debugger/continue-to-location.js View 1 chunk +0 lines, -114 lines 0 comments Download
D test/inspector/debugger/continue-to-location-expected.txt View 1 chunk +0 lines, -31 lines 0 comments Download
D test/inspector/debugger/doesnt-step-into-injected-script.js View 1 chunk +0 lines, -32 lines 0 comments Download
D test/inspector/debugger/doesnt-step-into-injected-script-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D test/inspector/debugger/scope-skip-variables-with-empty-name.js View 1 chunk +0 lines, -42 lines 0 comments Download
D test/inspector/debugger/scope-skip-variables-with-empty-name-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D test/inspector/debugger/script-parsed-hash.js View 1 chunk +0 lines, -32 lines 0 comments Download
D test/inspector/debugger/script-parsed-hash-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D test/inspector/debugger/set-blackbox-patterns.js View 1 chunk +0 lines, -59 lines 0 comments Download
D test/inspector/debugger/set-blackbox-patterns-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D test/inspector/debugger/set-breakpoint-before-enabling.js View 1 chunk +0 lines, -17 lines 0 comments Download
D test/inspector/debugger/set-breakpoint-before-enabling-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D test/inspector/debugger/set-script-source.js View 1 chunk +0 lines, -151 lines 0 comments Download
D test/inspector/debugger/set-script-source-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D test/inspector/debugger/step-over-caught-exception.js View 1 chunk +0 lines, -76 lines 0 comments Download
D test/inspector/debugger/step-over-caught-exception-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D test/inspector/debugger/stepping-with-blackboxed-ranges.js View 1 chunk +0 lines, -126 lines 0 comments Download
D test/inspector/debugger/stepping-with-blackboxed-ranges-expected.txt View 1 chunk +0 lines, -54 lines 0 comments Download
D test/inspector/debugger/update-call-frame-scopes.js View 1 chunk +0 lines, -64 lines 0 comments Download
D test/inspector/debugger/update-call-frame-scopes-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M test/inspector/inspector.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D test/inspector/inspector.status View 1 chunk +0 lines, -7 lines 0 comments Download
M test/inspector/inspector-impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M test/inspector/inspector-impl.cc View 2 chunks +4 lines, -14 lines 0 comments Download
D test/inspector/inspector-test.cc View 1 chunk +0 lines, -222 lines 0 comments Download
D test/inspector/json-parse.js View 1 chunk +0 lines, -14 lines 0 comments Download
D test/inspector/json-parse-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D test/inspector/protocol-test.js View 1 chunk +0 lines, -177 lines 0 comments Download
D test/inspector/runtime/await-promise.js View 1 chunk +0 lines, -135 lines 0 comments Download
D test/inspector/runtime/await-promise-expected.txt View 1 chunk +0 lines, -104 lines 0 comments Download
D test/inspector/runtime/call-function-on-async.js View 1 chunk +0 lines, -142 lines 0 comments Download
D test/inspector/runtime/call-function-on-async-expected.txt View 1 chunk +0 lines, -125 lines 0 comments Download
D test/inspector/runtime/clear-of-command-line-api.js View 1 chunk +0 lines, -120 lines 0 comments Download
D test/inspector/runtime/clear-of-command-line-api-expected.txt View 1 chunk +0 lines, -127 lines 0 comments Download
D test/inspector/runtime/compile-script.js View 1 chunk +0 lines, -61 lines 0 comments Download
D test/inspector/runtime/compile-script-expected.txt View 1 chunk +0 lines, -51 lines 0 comments Download
D test/inspector/runtime/console-api-repeated-in-console.js View 1 chunk +0 lines, -37 lines 0 comments Download
D test/inspector/runtime/console-api-repeated-in-console-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D test/inspector/runtime/console-deprecated-methods.js View 1 chunk +0 lines, -28 lines 0 comments Download
D test/inspector/runtime/console-deprecated-methods-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D test/inspector/runtime/console-line-and-column.js View 1 chunk +0 lines, -35 lines 0 comments Download
D test/inspector/runtime/console-line-and-column-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download
D test/inspector/runtime/console-log-doesnt-run-microtasks.js View 1 chunk +0 lines, -26 lines 0 comments Download
D test/inspector/runtime/console-log-doesnt-run-microtasks-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D test/inspector/runtime/console-timestamp.js View 1 chunk +0 lines, -24 lines 0 comments Download
D test/inspector/runtime/console-timestamp-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D test/inspector/runtime/evaluate-async.js View 1 chunk +0 lines, -68 lines 0 comments Download
D test/inspector/runtime/evaluate-async-expected.txt View 1 chunk +0 lines, -81 lines 0 comments Download
D test/inspector/runtime/evaluate-with-context-id-equal-zero.js View 1 chunk +0 lines, -14 lines 0 comments Download
D test/inspector/runtime/evaluate-with-context-id-equal-zero-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D test/inspector/runtime/get-properties.js View 1 chunk +0 lines, -220 lines 0 comments Download
D test/inspector/runtime/get-properties-expected.txt View 1 chunk +0 lines, -39 lines 0 comments Download
D test/inspector/runtime/get-properties-on-proxy.js View 1 chunk +0 lines, -101 lines 0 comments Download
D test/inspector/runtime/get-properties-on-proxy-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D test/inspector/runtime/get-properties-preview.js View 1 chunk +0 lines, -25 lines 0 comments Download
D test/inspector/runtime/get-properties-preview-expected.txt View 1 chunk +0 lines, -32 lines 0 comments Download
D test/inspector/runtime/property-on-console-proto.js View 1 chunk +0 lines, -26 lines 0 comments Download
D test/inspector/runtime/property-on-console-proto-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D test/inspector/runtime/run-script-async.js View 1 chunk +0 lines, -133 lines 0 comments Download
D test/inspector/runtime/run-script-async-expected.txt View 1 chunk +0 lines, -157 lines 0 comments Download
M test/inspector/task-runner.cc View 1 chunk +3 lines, -0 lines 0 comments Download
D test/inspector/testcfg.py View 1 chunk +0 lines, -109 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2379303002/1
4 years, 2 months ago (2016-09-30 09:22:10 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 09:25:25 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 09:25:37 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ee0d69910be28e29ed0f2d1195f67a43f7921f9c
Cr-Commit-Position: refs/heads/master@{#39908}

Powered by Google App Engine
This is Rietveld 408576698