Rename RFO::FrameWillClose() to reflect its actual purpose.

chrome/renderer/page_load_histograms.h

Index: chrome/renderer/page_load_histograms.h
diff --git a/chrome/renderer/page_load_histograms.h b/chrome/renderer/page_load_histograms.h
index 7cc37559aa77e7840712c707ad9e9c12fdfd6f3b..5e72f1d6001956cc0995867ba6fa6a0cfb93d303 100644
--- a/chrome/renderer/page_load_histograms.h
+++ b/chrome/renderer/page_load_histograms.h
@@ -9,6 +9,7 @@
 #define CHROME_RENDERER_PAGE_LOAD_HISTOGRAMS_H_
 
 #include "base/macros.h"
+#include "content/public/renderer/render_frame_observer.h"
 #include "content/public/renderer/render_view_observer.h"
 
 namespace blink {
@@ -19,18 +20,17 @@ namespace content {
 class DocumentState;
 }
 
-class PageLoadHistograms : public content::RenderViewObserver {
+class PageLoadHistograms : public content::RenderFrameObserver {
  public:
-  explicit PageLoadHistograms(content::RenderView* render_view);
+  explicit PageLoadHistograms(content::RenderFrame* render_frame);
   ~PageLoadHistograms() override;
 
  private:
-  // RenderViewObserver implementation.
-  void FrameWillClose(blink::WebFrame* frame) override;
-  void ClosePage() override;
+  // RenderFrameObserver implementation.
+  void WillCommitProvisionalLoad() override;
   void OnDestruct() override;
 
-  // Dump all page load histograms appropriate for the given frame.
+  // Dump all page load histograms appropriate for the associated frame.
   //
   // This method will only dump once-per-instance, so it is safe to call
   // multiple times.
@@ -49,11 +49,28 @@ class PageLoadHistograms : public content::RenderViewObserver {
   // redirect had been done (the user never requested the page)
   // Also, it's possible to load a page without ever laying it out
   // so first_paint and first_paint_after_load can be 0.
-  void Dump(blink::WebFrame* frame);
+  void Dump();
 
   void LogPageLoadTime(const content::DocumentState* load_times,
                        const blink::WebDataSource* ds) const;
 
+  // PageLoadHistograms needs the ClosePage() notification, but it's problematic
+  // to inherit from both. Embed the RVO in a small helper class instead.

[Charlie Harrison, 2016/09/30 18:56:56]

"both RVO and RFO"

[dcheng, 2016/10/04 17:16:28]

Done.

+  class Helper : public content::RenderViewObserver {
+   public:
+    explicit Helper(PageLoadHistograms* histograms);

[jochen (gone - plz use gerrit), 2016/10/04 09:32:44]

should there be a virtual dtor as well?

[dcheng, 2016/10/04 17:16:28]

RVO already has a virtual dtor, so it's not necessary to repeat it here.

clang (usually) warns if you forget to have a virtual dtor here.

+
+    // RenderViewObserver implementation.
+    void ClosePage() override;
+    void OnDestruct() override;
+
+   private:
+    // The Helper is owned by PageLoadHistograms.
+    PageLoadHistograms* const histograms_;
+  };

[jochen (gone - plz use gerrit), 2016/10/04 09:32:44]

disallow_copy_and_assign

[dcheng, 2016/10/04 17:16:28]

Done.

+
+  Helper helper_;
+
   DISALLOW_COPY_AND_ASSIGN(PageLoadHistograms);
 };