Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Side by Side Diff: content/renderer/render_frame_impl.cc

Issue 2379293002: Rename RFO::FrameWillClose() to reflect its actual purpose. (Closed)
Patch Set: Fix silly typo Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/media/user_media_client_impl_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_frame_impl.h" 5 #include "content/renderer/render_frame_impl.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 2919 matching lines...) Expand 10 before | Expand all | Expand 10 after
2930 // Object is invalid after this point. 2930 // Object is invalid after this point.
2931 } 2931 }
2932 2932
2933 void RenderFrameImpl::frameFocused() { 2933 void RenderFrameImpl::frameFocused() {
2934 Send(new FrameHostMsg_FrameFocused(routing_id_)); 2934 Send(new FrameHostMsg_FrameFocused(routing_id_));
2935 } 2935 }
2936 2936
2937 void RenderFrameImpl::willCommitProvisionalLoad(blink::WebLocalFrame* frame) { 2937 void RenderFrameImpl::willCommitProvisionalLoad(blink::WebLocalFrame* frame) {
2938 DCHECK_EQ(frame_, frame); 2938 DCHECK_EQ(frame_, frame);
2939 2939
2940 // TODO(dcheng): Rename observer to FrameWillCommitProvisionalLoad. 2940 FOR_EACH_OBSERVER(RenderFrameObserver, observers_,
2941 FOR_EACH_OBSERVER(RenderFrameObserver, observers_, FrameWillClose()); 2941 WillCommitProvisionalLoad());
2942 FOR_EACH_OBSERVER(RenderViewObserver, render_view_->observers(),
2943 FrameWillClose(frame));
2944 } 2942 }
2945 2943
2946 void RenderFrameImpl::didChangeName(const blink::WebString& name, 2944 void RenderFrameImpl::didChangeName(const blink::WebString& name,
2947 const blink::WebString& unique_name) { 2945 const blink::WebString& unique_name) {
2948 // TODO(alexmos): According to https://crbug.com/169110, sending window.name 2946 // TODO(alexmos): According to https://crbug.com/169110, sending window.name
2949 // updates may have performance implications for benchmarks like SunSpider. 2947 // updates may have performance implications for benchmarks like SunSpider.
2950 // For now, send these updates only for --site-per-process, which needs to 2948 // For now, send these updates only for --site-per-process, which needs to
2951 // replicate frame names to frame proxies, and when 2949 // replicate frame names to frame proxies, and when
2952 // |report_frame_name_changes| is set (used by <webview>). If needed, this 2950 // |report_frame_name_changes| is set (used by <webview>). If needed, this
2953 // can be optimized further by only sending the update if there are any 2951 // can be optimized further by only sending the update if there are any
(...skipping 3476 matching lines...) Expand 10 before | Expand all | Expand 10 after
6430 // event target. Potentially a Pepper plugin will receive the event. 6428 // event target. Potentially a Pepper plugin will receive the event.
6431 // In order to tell whether a plugin gets the last mouse event and which it 6429 // In order to tell whether a plugin gets the last mouse event and which it
6432 // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets 6430 // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets
6433 // the event, it will notify us via DidReceiveMouseEvent() and set itself as 6431 // the event, it will notify us via DidReceiveMouseEvent() and set itself as
6434 // |pepper_last_mouse_event_target_|. 6432 // |pepper_last_mouse_event_target_|.
6435 pepper_last_mouse_event_target_ = nullptr; 6433 pepper_last_mouse_event_target_ = nullptr;
6436 #endif 6434 #endif
6437 } 6435 }
6438 6436
6439 } // namespace content 6437 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/media/user_media_client_impl_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698