Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: components/arc/arc_bridge_service_impl.cc

Issue 2379223004: Switch from Delegate to Observer. (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/arc/arc_bridge_service_impl.h ('k') | components/arc/arc_bridge_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/arc/arc_bridge_service_impl.cc
diff --git a/components/arc/arc_bridge_service_impl.cc b/components/arc/arc_bridge_service_impl.cc
index 4cf543f912ee1bdf0c9648a0b092202553e7bf1c..388ab0ce068ce68592107327975bd7107caa5b8b 100644
--- a/components/arc/arc_bridge_service_impl.cc
+++ b/components/arc/arc_bridge_service_impl.cc
@@ -17,7 +17,6 @@
#include "chromeos/chromeos_switches.h"
#include "chromeos/dbus/dbus_method_call_status.h"
#include "chromeos/dbus/dbus_thread_manager.h"
-#include "components/arc/arc_bridge_host_impl.h"
#include "components/prefs/pref_registry_simple.h"
#include "components/prefs/pref_service.h"
@@ -38,6 +37,9 @@ ArcBridgeServiceImpl::ArcBridgeServiceImpl()
}
ArcBridgeServiceImpl::~ArcBridgeServiceImpl() {
+ if (bootstrap_)
+ bootstrap_->RemoveObserver(this);
+
DCHECK(g_arc_bridge_service == this);
g_arc_bridge_service = nullptr;
}
@@ -82,9 +84,12 @@ void ArcBridgeServiceImpl::PrerequisitesChanged() {
VLOG(0) << "Prerequisites met, starting ARC";
SetStopReason(StopReason::SHUTDOWN);
+ if (bootstrap_)
+ bootstrap_->RemoveObserver(this);
+
SetState(State::CONNECTING);
bootstrap_ = factory_.Run();
- bootstrap_->set_delegate(this);
+ bootstrap_->AddObserver(this);
bootstrap_->Start();
} else {
if (session_started_)
@@ -107,22 +112,18 @@ void ArcBridgeServiceImpl::StopInstance() {
VLOG(1) << "Stopping ARC";
DCHECK(bootstrap_.get());
SetState(State::STOPPING);
- arc_bridge_host_.reset();
// Note: this can call OnStopped() internally as a callback.
bootstrap_->Stop();
}
-void ArcBridgeServiceImpl::OnConnectionEstablished(
- mojom::ArcBridgeInstancePtr instance) {
+void ArcBridgeServiceImpl::OnReady() {
DCHECK(CalledOnValidThread());
if (state() != State::CONNECTING) {
VLOG(1) << "StopInstance() called while connecting";
return;
}
- arc_bridge_host_.reset(new ArcBridgeHostImpl(std::move(instance)));
-
// The container can be considered to have been successfully launched, so
// restart if the connection goes down without being requested.
reconnect_ = true;
@@ -133,7 +134,7 @@ void ArcBridgeServiceImpl::OnConnectionEstablished(
void ArcBridgeServiceImpl::OnStopped(StopReason stop_reason) {
DCHECK(CalledOnValidThread());
VLOG(0) << "ARC stopped: " << stop_reason;
- arc_bridge_host_.reset();
+ bootstrap_->RemoveObserver(this);
bootstrap_.reset();
SetStopReason(stop_reason);
SetState(State::STOPPED);
« no previous file with comments | « components/arc/arc_bridge_service_impl.h ('k') | components/arc/arc_bridge_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698