Switch from Delegate to Observer.

Switch from Delegate to Observer.

This CL switches the interface between ArcBridgeBootstrap
and ArcBridgeServiceImpl from Delegate to Observer.
Also, ArcBridgeHost will be instantiated in ArcBridgeBootstrap
and kept in it.

BUG=633258
TEST=Trybots.

Committed: https://crrev.com/a028d09fb9831cf4a036791431e771ab7d6bfdaa
Cr-Commit-Position: refs/heads/master@{#423051}

[hidehiko, 2016-09-30 17:43:27]

The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 17:43:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 17:58:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 17:58:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hidehiko, 2016-09-30 18:11:40]

The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 18:12:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 19:11:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 19:11:59]

Dry run: This issue passed the CQ dry run.

[hidehiko, 2016-09-30 19:15:58]

hidehiko@chromium.org changed reviewers:
+ lhchavez@chromium.org

[hidehiko, 2016-09-30 19:15:58]

PTAL.

[hidehiko, 2016-10-03 12:59:16]

On 2016/09/30 19:15:58, hidehiko wrote:
> PTAL.

ping?

[Luis Héctor Chávez, 2016-10-03 18:05:32]

https://codereview.chromium.org/2379223004/diff/40001/components/arc/arc_brid...
File components/arc/arc_bridge_bootstrap.h (right):

https://codereview.chromium.org/2379223004/diff/40001/components/arc/arc_brid...
components/arc/arc_bridge_bootstrap.h:31: public:
hmmm looks like we (I?) missed adding a virtual destructor in the original
implementation. Can you add it please?

https://codereview.chromium.org/2379223004/diff/40001/components/arc/arc_brid...
components/arc/arc_bridge_bootstrap.h:38: };
nit: DISALLOW_COPY_AND_ASSIGN(Observer); ?

https://codereview.chromium.org/2379223004/diff/40001/components/arc/arc_brid...
File components/arc/arc_bridge_service_impl.cc (right):

https://codereview.chromium.org/2379223004/diff/40001/components/arc/arc_brid...
components/arc/arc_bridge_service_impl.cc:89: bootstrap_ = factory_.Run();
Should you unregister the previous bootstrap here if it exists? Otherwise
there'll be a DCHECK that its observer list is non-empty. Or is there a
guarantee that OnStopped will definitely be called before? If there is (e.g.
successive Shutdown()/HandleStartup() calls being guarded by ArcAuthService or
something like that), please document it here.

[hidehiko, 2016-10-04 05:10:55]

The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 05:11:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 05:13:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 05:13:22]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[hidehiko, 2016-10-04 05:34:28]

The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 05:34:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hidehiko, 2016-10-04 05:34:45]

Thank you for review. PTAL.

https://codereview.chromium.org/2379223004/diff/40001/components/arc/arc_brid...
File components/arc/arc_bridge_bootstrap.h (right):

https://codereview.chromium.org/2379223004/diff/40001/components/arc/arc_brid...
components/arc/arc_bridge_bootstrap.h:31: public:
On 2016/10/03 18:05:32, Luis Héctor Chávez wrote:
> hmmm looks like we (I?) missed adding a virtual destructor in the original
> implementation. Can you add it please?

Good catch. Done.

https://codereview.chromium.org/2379223004/diff/40001/components/arc/arc_brid...
components/arc/arc_bridge_bootstrap.h:38: };
On 2016/10/03 18:05:32, Luis Héctor Chávez wrote:
> nit: DISALLOW_COPY_AND_ASSIGN(Observer); ?

Done.

https://codereview.chromium.org/2379223004/diff/40001/components/arc/arc_brid...
File components/arc/arc_bridge_service_impl.cc (right):

https://codereview.chromium.org/2379223004/diff/40001/components/arc/arc_brid...
components/arc/arc_bridge_service_impl.cc:89: bootstrap_ = factory_.Run();
On 2016/10/03 18:05:32, Luis Héctor Chávez wrote:
> Should you unregister the previous bootstrap here if it exists? Otherwise
> there'll be a DCHECK that its observer list is non-empty. Or is there a
> guarantee that OnStopped will definitely be called before? If there is (e.g.
> successive Shutdown()/HandleStartup() calls being guarded by ArcAuthService or
> something like that), please document it here.

Added RemoveObserver, which is much safer.

[commit-bot: I haz the power, 2016-10-04 06:39:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 06:39:24]

Dry run: This issue passed the CQ dry run.

[Luis Héctor Chávez, 2016-10-04 15:53:01]

lgtm

[hidehiko, 2016-10-05 02:14:50]

The CQ bit was checked by hidehiko@chromium.org

[commit-bot: I haz the power, 2016-10-05 02:15:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 02:20:45]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-05 02:24:17]

Description was changed from

==========
Switch from Delegate to Observer.

This CL switches the interface between ArcBridgeBootstrap
and ArcBridgeServiceImpl from Delegate to Observer.
Also, ArcBridgeHost will be instantiated in ArcBridgeBootstrap
and kept in it.

BUG=633258
TEST=Trybots.
==========

to

==========
Switch from Delegate to Observer.

This CL switches the interface between ArcBridgeBootstrap
and ArcBridgeServiceImpl from Delegate to Observer.
Also, ArcBridgeHost will be instantiated in ArcBridgeBootstrap
and kept in it.

BUG=633258
TEST=Trybots.

Committed: https://crrev.com/a028d09fb9831cf4a036791431e771ab7d6bfdaa
Cr-Commit-Position: refs/heads/master@{#423051}
==========

[commit-bot: I haz the power, 2016-10-05 02:24:18]

Patchset 5 (id:??) landed as
https://crrev.com/a028d09fb9831cf4a036791431e771ab7d6bfdaa
Cr-Commit-Position: refs/heads/master@{#423051}