Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 23792008: Skip intl tests from test262 when intl support is disabled. (Closed)

Created:
7 years, 3 months ago by Michael Achenbach
Modified:
7 years, 3 months ago
CC:
v8-dev, Jakob Kummerow
Visibility:
Public.

Description

Skip intl tests from test262 when intl support is disabled. Skips the whole intl directory if intl support is disabled through the test driver. One test outside the intl directory is skipped separately. It will be handled in an extra CL. R=jochen@chromium.org, mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16854

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M test/test262/test262.status View 1 chunk +3 lines, -0 lines 0 comments Download
M test/test262/testcfg.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/run-deopt-fuzzer.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/run-tests.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/testrunner/objects/context.py View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
PTAL
7 years, 3 months ago (2013-09-20 08:52:13 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 3 months ago (2013-09-20 08:55:28 UTC) #2
Michael Starzinger
LGTM.
7 years, 3 months ago (2013-09-20 08:59:55 UTC) #3
Michael Achenbach
7 years, 3 months ago (2013-09-20 09:26:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r16854 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698