Issue 23791005: Revert 221982 "file_manager: Remove FileWatchChangedEntry from f..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23791005: Revert 221982 "file_manager: Remove FileWatchChangedEntry from f..." (Closed)

Created:
7 years, 3 months ago by satorux1

Modified:
7 years, 3 months ago

Reviewers:
satorux1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 221982 "file_manager: Remove FileWatchChangedEntry from f..." Broke DriveFileSystemExtensionApiTest.FileWatch http://build.chromium.org/p/tryserver.chromium/builders/linux_chromeos/builds/151979 > file_manager: Remove FileWatchChangedEntry from fileBrowserPrivate > > This type is not in use, and we don't plan to use this any time soon. > We should add it back when it's needed. > > BUG=257916 > TEST=Files.app works as before > R=benwells@chromium.org, mtomasz@chromium.org > > Review URL: https://codereview.chromium.org/23956009 TBR=satorux@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221990

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -0 lines)			Patch
	M	trunk/src/chrome/browser/chromeos/extensions/file_manager/event_router.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	trunk/src/chrome/common/extensions/api/file_browser_private.json	View		2 chunks	+20 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r221990.