Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2379063002: Revert of [modules] Properly initialize declared variables. (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [modules] Properly initialize declared variables. (patchset #5 id:80001 of https://codereview.chromium.org/2375793002/ ) Reason for revert: Suspect for causing win64 debug problems: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20debug/builds/12646 Original issue's description: > [modules] Properly initialize declared variables. > > Before evaluating a module, all variables declared at the top-level > in _any_ of the modules in the dependency graph must be initialized. > This is observable because a module A can access a variable imported > from module B (e.g. a function) at a point when module B's body hasn't > been evaluated yet. > > We achieve this by implementing modules internally as generators with > two states (not initialized, initialized). > > R=adamk@chromium.org > BUG=v8:1569 > > Committed: https://crrev.com/f4dfb6fbe1cdd9a0f287a1a9c496e1f69f6f5d20 > Cr-Commit-Position: refs/heads/master@{#39871} TBR=adamk@chromium.org,mstarzinger@chromium.org,neis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:1569 Committed: https://crrev.com/7496c9de941119239fe489764fb24ec7bb2ebc37 Cr-Commit-Position: refs/heads/master@{#39873}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -166 lines) Patch
M src/ast/scopes.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/contexts.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/globals.h View 3 chunks +1 line, -8 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 3 chunks +2 lines, -9 lines 0 comments Download
M src/objects.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.cc View 2 chunks +8 lines, -19 lines 0 comments Download
M src/parsing/parser.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/parsing/parser.cc View 7 chunks +36 lines, -43 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallRuntime.golden View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/modules-error-trace.js View 1 chunk +0 lines, -9 lines 0 comments Download
D test/mjsunit/modules-init1.js View 1 chunk +0 lines, -9 lines 0 comments Download
D test/mjsunit/modules-init2.js View 1 chunk +0 lines, -8 lines 0 comments Download
D test/mjsunit/modules-init3.js View 1 chunk +0 lines, -20 lines 0 comments Download
D test/mjsunit/modules-skip-init1.js View 1 chunk +0 lines, -6 lines 0 comments Download
D test/mjsunit/modules-skip-init3.js View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [modules] Properly initialize declared variables.
4 years, 2 months ago (2016-09-29 15:09:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2379063002/1
4 years, 2 months ago (2016-09-29 15:10:00 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 15:10:17 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 15:10:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7496c9de941119239fe489764fb24ec7bb2ebc37
Cr-Commit-Position: refs/heads/master@{#39873}

Powered by Google App Engine
This is Rietveld 408576698