Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 237903002: Clean up mac gpu switching code a little. (Closed)

Created:
6 years, 8 months ago by Zhenyao Mo
Modified:
6 years, 8 months ago
CC:
chromium-reviews, piman+watch_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Clean up mac gpu switching code a little. This may not helps with the crash we observed in the bug report, but at least the code is more testable. Also, re-enable the gpu_data_manager_impl_private_unittest.cc which was accidently disabled. BUG=361991 TEST=content_unittests R=kbr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263971

Patch Set 1 #

Patch Set 2 : fix linux #

Patch Set 3 : Fix linux test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -52 lines) Patch
M content/browser/gpu/gpu_data_manager_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 2 chunks +39 lines, -29 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private_unittest.cc View 1 2 20 chunks +105 lines, -23 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Zhenyao Mo
kbr: please take a look.
6 years, 8 months ago (2014-04-14 21:58:38 UTC) #1
Ken Russell (switch to Gerrit)
LGTM. The compilation failures are caused by this patch, so obviously, please fix before committing.
6 years, 8 months ago (2014-04-15 00:25:45 UTC) #2
Zhenyao Mo
The CQ bit was checked by zmo@chromium.org
6 years, 8 months ago (2014-04-15 00:36:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/237903002/20001
6 years, 8 months ago (2014-04-15 00:36:57 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-15 01:11:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg
6 years, 8 months ago (2014-04-15 01:11:11 UTC) #6
Zhenyao Mo
The CQ bit was checked by zmo@chromium.org
6 years, 8 months ago (2014-04-15 16:55:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/237903002/30001
6 years, 8 months ago (2014-04-15 16:57:36 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-15 19:41:29 UTC) #9
Message was sent while issue was closed.
Change committed as 263971

Powered by Google App Engine
This is Rietveld 408576698