Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: syzygy/agent/asan/runtime.cc

Issue 2379023002: [SyzyAsan] Fix overflow error in ShadowWalker for 4GB 32-bit processes. (Closed)
Patch Set: Fix comments. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: syzygy/agent/asan/runtime.cc
diff --git a/syzygy/agent/asan/runtime.cc b/syzygy/agent/asan/runtime.cc
index 9eab017fa7918ec113050dd87a9f73d2b3205790..f1503bb11695f1ed18921b41ba2ee7f55a96d71f 100644
--- a/syzygy/agent/asan/runtime.cc
+++ b/syzygy/agent/asan/runtime.cc
@@ -943,7 +943,8 @@ void AsanRuntime::WriteCorruptHeapInfo(
++block_infos;
// Use a shadow walker to find the first corrupt block in this range and
- // copy its metadata.
+ // copy its metadata. It's fine for the upper bound address calculation to
+ // overflow to 0, as this represents the end of the 4GB address space.
ShadowWalker shadow_walker(
shadow(), false,
reinterpret_cast<const uint8_t*>(corrupt_ranges[i].address),

Powered by Google App Engine
This is Rietveld 408576698