Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2378973003: Revert of [wasm] Remove improper assembler check for grow memory. (Closed)

Created:
4 years, 2 months ago by adamk
Modified:
4 years, 2 months ago
Reviewers:
gdeepti, titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] Remove improper assembler check for grow memory. (patchset #2 id:20001 of https://codereview.chromium.org/2376153003/ ) Reason for revert: grow-memory test now fails on Linux dbg, blocking the CQ: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug/builds/11217 Original issue's description: > [wasm] Remove improper assembler check for grow memory. > > Note that the offset can still be out of bounds, even after grow memory. The calculation of the remaining size can overflow. > > R=gdeepti@chromium.org > BUG=chromium:644670 > > Committed: https://crrev.com/e6071a9c067e07304329250e040b652fb82e9b5e > Cr-Commit-Position: refs/heads/master@{#39886} TBR=gdeepti@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:644670 Committed: https://crrev.com/a2a9b4a7eaa56908c4611b66a87590dfb917f3be Cr-Commit-Position: refs/heads/master@{#39889}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -25 lines) Patch
M src/assembler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/grow-memory.js View 2 chunks +1 line, -25 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
adamk
Created Revert of [wasm] Remove improper assembler check for grow memory.
4 years, 2 months ago (2016-09-29 21:54:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378973003/1
4 years, 2 months ago (2016-09-29 21:54:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 21:54:42 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 21:55:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2a9b4a7eaa56908c4611b66a87590dfb917f3be
Cr-Commit-Position: refs/heads/master@{#39889}

Powered by Google App Engine
This is Rietveld 408576698