Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2378973002: Revert of Add unit tests for AddToHomescreenDataFetcher (Closed)

Created:
4 years, 2 months ago by tsergeant
Modified:
4 years, 2 months ago
CC:
chromium-reviews, jam, dominickn+watch_chromium.org, darin-cc_chromium.org, Xi Han
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add unit tests for AddToHomescreenDataFetcher (patchset #3 id:60001 of https://codereview.chromium.org/2354363007/ ) Reason for revert: The new AddToHomescreenDataFetcherTestCommon.ManifestFetchTimesOut test is flaky on android_n5x_swarming_rel. See crbug.com/651047 for further details. Original issue's description: > Add unit tests for AddToHomescreenDataFetcher > > This CL makes some of the instrumentation tests in AddToHomescreenManagerTest > unit tests for AddToHomescreenDataFetcher instead > > BUG=None > R=dominickn, michaeln > TBR=sky (For moving a file from content_browsertests to test_support in content/test/BUILD.gn) > > Committed: https://crrev.com/4207dcd418e427ebd7d344d305a8d19414dd0279 > Cr-Commit-Position: refs/heads/master@{#421387} TBR=dominickn@chromium.org,michaeln@chromium.org,pkotwicz@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=None

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -315 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenManagerTest.java View 4 chunks +93 lines, -0 lines 0 comments Download
D chrome/browser/android/webapps/DEPS View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc View 1 chunk +0 lines, -303 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tsergeant
Created Revert of Add unit tests for AddToHomescreenDataFetcher
4 years, 2 months ago (2016-09-29 00:34:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378973002/1
4 years, 2 months ago (2016-09-29 00:35:23 UTC) #3
tsergeant
On 2016/09/29 00:35:23, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 2 months ago (2016-09-29 00:39:08 UTC) #5
tsergeant
4 years, 2 months ago (2016-09-29 01:47:29 UTC) #6
On 2016/09/29 00:39:08, tsergeant wrote:
> On 2016/09/29 00:35:23, commit-bot: I haz the power wrote:
> > CQ is trying da patch. Follow status at
> >  
> >
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
> 
> Actually, something is weird about the log output from this bot. Gonna look
more
> into it before I go ahead with landing this revert.

I've filed crbug.com/651279. Closing this CL, since it's difficult to tell if
there's any flakes unrelated to the general craziness going on with that bot.

Powered by Google App Engine
This is Rietveld 408576698