Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2378953003: CoreServices is not available on iOS. Don't add it as a dependency. (Closed)

Created:
4 years, 2 months ago by Chinmay
Modified:
4 years, 2 months ago
Reviewers:
zra, Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

CoreServices is not available on iOS. Don't add it as a dependency. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/cfbf1a511e6e64d35789e34e161a7b10a88a439c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M runtime/bin/BUILD.gn View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Chinmay
4 years, 2 months ago (2016-09-29 18:03:35 UTC) #2
zra
lgtm
4 years, 2 months ago (2016-09-29 18:05:03 UTC) #3
Chinmay
4 years, 2 months ago (2016-09-29 18:05:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cfbf1a511e6e64d35789e34e161a7b10a88a439c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698