services/video_capture/public/interfaces/video_frame_receiver.mojom - Issue 2378943002: Let clients interact with VideoCaptureDeviceClient instead of VideoCaptureDevice

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/video_capture/public/interfaces/video_frame_receiver.mojom

Issue 2378943002: Let clients interact with VideoCaptureDeviceClient instead of VideoCaptureDevice (Closed)

Patch Set: Remove method AsClientBuffer() Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « services/video_capture/public/interfaces/video_capture_device_proxy.mojom ('k') | services/video_capture/receiver_mojo_to_media_adapter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/video_capture/public/interfaces/video_frame_receiver.mojom

diff --git a/services/video_capture/public/interfaces/video_capture_device_client.mojom b/services/video_capture/public/interfaces/video_frame_receiver.mojom

similarity index 60%

rename from services/video_capture/public/interfaces/video_capture_device_client.mojom

rename to services/video_capture/public/interfaces/video_frame_receiver.mojom

index 810d8aa73740d6266e3a452a13e0be3b04d30a02..d4eaac97254f9c9918a6e7186efa5770a543536c 100644

--- a/services/video_capture/public/interfaces/video_capture_device_client.mojom

+++ b/services/video_capture/public/interfaces/video_frame_receiver.mojom

@@ -7,8 +7,10 @@ module video_capture.mojom;

import "media/mojo/interfaces/media_types.mojom";

// Callback interface for receiving data and messages from a started

-// VideoCaptureDevice.

-interface VideoCaptureDeviceClient {

- OnFrameAvailable(media.mojom.VideoFrame frame);

- OnError(string error);

+// VideoCaptureDeviceProxy.

+interface VideoFrameReceiver {

+ OnIncomingCapturedVideoFrame(media.mojom.VideoFrame frame);

+ OnError();

+ OnLog(string message);

+ OnBufferDestroyed(int32 buffer_id_to_drop);

};