Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: services/video_capture/video_capture_service.cc

Issue 2378943002: Let clients interact with VideoCaptureDeviceClient instead of VideoCaptureDevice (Closed)
Patch Set: Remove method AsClientBuffer() Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « services/video_capture/video_capture_device_proxy_impl.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/video_capture/video_capture_service.h" 5 #include "services/video_capture/video_capture_service.h"
6 6
7 #include "media/capture/video/fake_video_capture_device.h" 7 #include "media/capture/video/fake_video_capture_device.h"
8 #include "media/capture/video/video_capture_jpeg_decoder.h"
8 #include "services/video_capture/video_capture_device_factory_impl.h" 9 #include "services/video_capture/video_capture_device_factory_impl.h"
9 10
10 namespace { 11 namespace {
11 static const char kFakeDeviceDisplayName[] = "Fake Video Capture Device"; 12 static const char kFakeDeviceDisplayName[] = "Fake Video Capture Device";
12 static const char kFakeDeviceId[] = "FakeDeviceId"; 13 static const char kFakeDeviceId[] = "FakeDeviceId";
13 static const char kFakeModelId[] = "FakeModelId"; 14 static const char kFakeModelId[] = "FakeModelId";
14 static const float kFakeCaptureDefaultFrameRate = 20.0f; 15 static const float kFakeCaptureDefaultFrameRate = 20.0f;
16
17 // TODO(chfremer): Replace with an actual decoder factory.
18 // https://crbug.com/584797
19 std::unique_ptr<media::VideoCaptureJpegDecoder> CreateJpegDecoder() {
20 return nullptr;
15 } 21 }
16 22
23 } // anonymous namespace
24
17 namespace video_capture { 25 namespace video_capture {
18 26
19 VideoCaptureService::VideoCaptureService() = default; 27 VideoCaptureService::VideoCaptureService() = default;
20 28
21 VideoCaptureService::~VideoCaptureService() = default; 29 VideoCaptureService::~VideoCaptureService() = default;
22 30
23 bool VideoCaptureService::OnConnect(const shell::Identity& remote_identity, 31 bool VideoCaptureService::OnConnect(const shell::Identity& remote_identity,
24 shell::InterfaceRegistry* registry) { 32 shell::InterfaceRegistry* registry) {
25 registry->AddInterface<mojom::VideoCaptureService>(this); 33 registry->AddInterface<mojom::VideoCaptureService>(this);
26 return true; 34 return true;
(...skipping 21 matching lines...) Expand all
48 mojom::VideoCaptureDeviceFactoryRequest request) { 56 mojom::VideoCaptureDeviceFactoryRequest request) {
49 LazyInitializeMockDeviceFactory(); 57 LazyInitializeMockDeviceFactory();
50 mock_factory_bindings_.AddBinding(mock_device_factory_.get(), 58 mock_factory_bindings_.AddBinding(mock_device_factory_.get(),
51 std::move(request)); 59 std::move(request));
52 } 60 }
53 61
54 void VideoCaptureService::AddDeviceToMockFactory( 62 void VideoCaptureService::AddDeviceToMockFactory(
55 mojom::MockVideoCaptureDevicePtr device, 63 mojom::MockVideoCaptureDevicePtr device,
56 mojom::VideoCaptureDeviceDescriptorPtr descriptor, 64 mojom::VideoCaptureDeviceDescriptorPtr descriptor,
57 const AddDeviceToMockFactoryCallback& callback) { 65 const AddDeviceToMockFactoryCallback& callback) {
66 LazyInitializeMockDeviceFactory();
58 mock_device_factory_->AddMockDevice(std::move(device), std::move(descriptor)); 67 mock_device_factory_->AddMockDevice(std::move(device), std::move(descriptor));
59 callback.Run(); 68 callback.Run();
60 } 69 }
61 70
62 void VideoCaptureService::LazyInitializeDeviceFactory() { 71 void VideoCaptureService::LazyInitializeDeviceFactory() {
63 if (device_factory_) 72 if (device_factory_)
64 return; 73 return;
65 device_factory_ = base::MakeUnique<VideoCaptureDeviceFactoryImpl>(); 74 device_factory_ = base::MakeUnique<VideoCaptureDeviceFactoryImpl>(
75 base::Bind(CreateJpegDecoder));
66 } 76 }
67 77
68 void VideoCaptureService::LazyInitializeFakeDeviceFactory() { 78 void VideoCaptureService::LazyInitializeFakeDeviceFactory() {
69 if (fake_device_factory_) 79 if (fake_device_factory_)
70 return; 80 return;
71 fake_device_factory_ = base::MakeUnique<VideoCaptureDeviceFactoryImpl>(); 81 fake_device_factory_ = base::MakeUnique<VideoCaptureDeviceFactoryImpl>(
82 base::Bind(CreateJpegDecoder));
72 auto fake_device_descriptor = mojom::VideoCaptureDeviceDescriptor::New(); 83 auto fake_device_descriptor = mojom::VideoCaptureDeviceDescriptor::New();
73 fake_device_descriptor->display_name = kFakeDeviceDisplayName; 84 fake_device_descriptor->display_name = kFakeDeviceDisplayName;
74 fake_device_descriptor->device_id = kFakeDeviceId; 85 fake_device_descriptor->device_id = kFakeDeviceId;
75 fake_device_descriptor->model_id = kFakeModelId; 86 fake_device_descriptor->model_id = kFakeModelId;
76 fake_device_descriptor->capture_api = mojom::VideoCaptureApi::UNKNOWN; 87 fake_device_descriptor->capture_api = mojom::VideoCaptureApi::UNKNOWN;
77 fake_device_descriptor->transport_type = 88 fake_device_descriptor->transport_type =
78 mojom::VideoCaptureTransportType::OTHER_TRANSPORT; 89 mojom::VideoCaptureTransportType::OTHER_TRANSPORT;
79 fake_device_factory_->AddMediaDevice( 90 fake_device_factory_->AddMediaDevice(
80 base::MakeUnique<media::FakeVideoCaptureDevice>( 91 base::MakeUnique<media::FakeVideoCaptureDevice>(
81 media::FakeVideoCaptureDevice::BufferOwnership::OWN_BUFFERS, 92 media::FakeVideoCaptureDevice::BufferOwnership::OWN_BUFFERS,
82 kFakeCaptureDefaultFrameRate), 93 kFakeCaptureDefaultFrameRate),
83 std::move(fake_device_descriptor)); 94 std::move(fake_device_descriptor));
84 } 95 }
85 96
86 void VideoCaptureService::LazyInitializeMockDeviceFactory() { 97 void VideoCaptureService::LazyInitializeMockDeviceFactory() {
87 if (mock_device_factory_) 98 if (mock_device_factory_)
88 return; 99 return;
89 mock_device_factory_ = base::MakeUnique<VideoCaptureDeviceFactoryImpl>(); 100 mock_device_factory_ = base::MakeUnique<VideoCaptureDeviceFactoryImpl>(
101 base::Bind(CreateJpegDecoder));
90 } 102 }
91 103
92 } // namespace video_capture 104 } // namespace video_capture
OLDNEW
« no previous file with comments | « services/video_capture/video_capture_device_proxy_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698