Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: services/video_capture/video_capture_device_proxy_impl.cc

Issue 2378943002: Let clients interact with VideoCaptureDeviceClient instead of VideoCaptureDevice (Closed)
Patch Set: mcasas comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/video_capture/video_capture_device_proxy_impl.h"
6
5 #include "base/logging.h" 7 #include "base/logging.h"
6 #include "services/video_capture/device_client_mojo_to_media_adapter.h" 8 #include "media/capture/video/video_capture_buffer_pool_impl.h"
9 #include "media/capture/video/video_capture_jpeg_decoder.h"
10 #include "services/video_capture/buffer_tracker_factory_impl.h"
7 #include "services/video_capture/mojo_media_conversions.h" 11 #include "services/video_capture/mojo_media_conversions.h"
8 #include "services/video_capture/video_capture_device_proxy_impl.h" 12 #include "services/video_capture/receiver_mojo_to_media_adapter.h"
9 13
10 namespace video_capture { 14 namespace video_capture {
11 15
12 VideoCaptureDeviceProxyImpl::VideoCaptureDeviceProxyImpl( 16 VideoCaptureDeviceProxyImpl::VideoCaptureDeviceProxyImpl(
13 std::unique_ptr<media::VideoCaptureDevice> device) 17 std::unique_ptr<media::VideoCaptureDevice> device,
14 : device_(std::move(device)) {} 18 const media::VideoCaptureJpegDecoderFactoryCB&
19 jpeg_decoder_factory_callback)
20 : device_(std::move(device)),
21 jpeg_decoder_factory_callback_(jpeg_decoder_factory_callback),
22 device_running_(false) {}
15 23
16 VideoCaptureDeviceProxyImpl::~VideoCaptureDeviceProxyImpl() { 24 VideoCaptureDeviceProxyImpl::~VideoCaptureDeviceProxyImpl() {
17 if (device_running_) 25 if (device_running_)
18 device_->StopAndDeAllocate(); 26 device_->StopAndDeAllocate();
19 } 27 }
20 28
21 void VideoCaptureDeviceProxyImpl::Start( 29 void VideoCaptureDeviceProxyImpl::Start(
22 mojom::VideoCaptureFormatPtr requested_format, 30 mojom::VideoCaptureFormatPtr requested_format,
23 mojom::ResolutionChangePolicy resolution_change_policy, 31 mojom::ResolutionChangePolicy resolution_change_policy,
24 mojom::PowerLineFrequency power_line_frequency, 32 mojom::PowerLineFrequency power_line_frequency,
25 mojom::VideoCaptureDeviceClientPtr client) { 33 mojom::VideoFrameReceiverPtr receiver) {
26 media::VideoCaptureParams params; 34 media::VideoCaptureParams params;
27 params.requested_format = ConvertFromMojoToMedia(std::move(requested_format)); 35 params.requested_format = ConvertFromMojoToMedia(std::move(requested_format));
28 params.resolution_change_policy = 36 params.resolution_change_policy =
29 ConvertFromMojoToMedia(resolution_change_policy); 37 ConvertFromMojoToMedia(resolution_change_policy);
30 params.power_line_frequency = ConvertFromMojoToMedia(power_line_frequency); 38 params.power_line_frequency = ConvertFromMojoToMedia(power_line_frequency);
31 client.set_connection_error_handler( 39
40 receiver.set_connection_error_handler(
32 base::Bind(&VideoCaptureDeviceProxyImpl::OnClientConnectionErrorOrClose, 41 base::Bind(&VideoCaptureDeviceProxyImpl::OnClientConnectionErrorOrClose,
33 base::Unretained(this))); 42 base::Unretained(this)));
34 auto media_client = 43
35 base::MakeUnique<DeviceClientMojoToMediaAdapter>(std::move(client)); 44 auto media_receiver =
36 device_->AllocateAndStart(params, std::move(media_client)); 45 base::MakeUnique<ReceiverMojoToMediaAdapter>(std::move(receiver));
46
47 // Create a dedicated buffer pool for the device usage session.
48 const int kMaxBufferCount = 2;
49 auto buffer_tracker_factory = base::MakeUnique<BufferTrackerFactoryImpl>();
50 scoped_refptr<media::VideoCaptureBufferPool> buffer_pool(
51 new media::VideoCaptureBufferPoolImpl(std::move(buffer_tracker_factory),
52 kMaxBufferCount));
53
54 auto device_client = base::MakeUnique<media::VideoCaptureDeviceClient>(
55 std::move(media_receiver), buffer_pool, jpeg_decoder_factory_callback_);
56
57 device_->AllocateAndStart(params, std::move(device_client));
37 device_running_ = true; 58 device_running_ = true;
38 } 59 }
39 60
40 void VideoCaptureDeviceProxyImpl::Stop() { 61 void VideoCaptureDeviceProxyImpl::Stop() {
41 device_->StopAndDeAllocate(); 62 device_->StopAndDeAllocate();
42 device_running_ = false; 63 device_running_ = false;
43 } 64 }
44 65
45 void VideoCaptureDeviceProxyImpl::OnClientConnectionErrorOrClose() { 66 void VideoCaptureDeviceProxyImpl::OnClientConnectionErrorOrClose() {
46 device_->StopAndDeAllocate(); 67 if (device_running_) {
68 device_->StopAndDeAllocate();
69 device_running_ = false;
70 }
47 } 71 }
48 72
49 } // namespace video_capture 73 } // namespace video_capture
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698