Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2378933005: Don't use cast overlay when using default controls. (Closed)

Created:
4 years, 2 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 2 months ago
Reviewers:
whywhat
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, nessy, Srirama, vcarbune.chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't use cast overlay when using default controls. It's now in the overflow menu. BUG=651428 Committed: https://crrev.com/198b03fa63070f44131733e799ab8e5494bfd687 Cr-Commit-Position: refs/heads/master@{#422315}

Patch Set 1 #

Patch Set 2 : update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -24 lines) Patch
M third_party/WebKit/LayoutTests/media/controls-cast-button-narrow.html View 1 2 chunks +7 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControls.cpp View 1 3 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
mlamouri (slow - plz ping)
4 years, 2 months ago (2016-09-30 14:06:45 UTC) #2
whywhat
lgtm
4 years, 2 months ago (2016-09-30 18:30:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378933005/20001
4 years, 2 months ago (2016-10-01 12:32:13 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-01 14:15:41 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-01 14:17:15 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/198b03fa63070f44131733e799ab8e5494bfd687
Cr-Commit-Position: refs/heads/master@{#422315}

Powered by Google App Engine
This is Rietveld 408576698