MD Settings: Skip unseen collapse animation

MD Settings: Skip unseen collapse animation

Don't play the collapse animation when hiding a page, because:

  1. The animation isn't visible, so it's extra work for nothing
  2. Messing with the container affects the new page

Although another CL[1] beat me to it, this would've also fixed the issue we
had navigating from a Settings sub-page to the About page, which used to jump
7.5px horizontally after a timeout due to us manipulating the scrollbar for
the animation.

[1] https://codereview.chromium.org/2379933003/

BUG=651616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/53c0cd015ae9b8d7cbf77a44aa8fb42f6ef568ec
Cr-Commit-Position: refs/heads/master@{#422285}

[michaelpg, 2016-09-30 02:17:49]

Description was changed from

==========
MD Settings: Remove flicker between pages

Don't play the collapse animation when hiding a page, because:
  1. The animation isn't visible
  2. Messing with the container affects the new page

This fixes navigating from a Settings sub-page to the About page, which used
to jump 7.5px horizontally after a timeout due to the sub-page's collapse
animation.

BUG=651616
==========

to

==========
MD Settings: Remove flicker between pages

Don't play the collapse animation when hiding a page, because:
  1. The animation isn't visible
  2. Messing with the container affects the new page

This fixes navigating from a Settings sub-page to the About page, which used
to jump 7.5px horizontally after a timeout due to the sub-page's collapse
animation.

BUG=651616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-09-30 02:43:39]

Description was changed from

==========
MD Settings: Remove flicker between pages

Don't play the collapse animation when hiding a page, because:
  1. The animation isn't visible
  2. Messing with the container affects the new page

This fixes navigating from a Settings sub-page to the About page, which used
to jump 7.5px horizontally after a timeout due to the sub-page's collapse
animation.

BUG=651616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Cancel unseen collapse animation

Don't play the collapse animation when hiding a page, because:

  1. The animation isn't visible, so it's extra work for nothing
  2. Messing with the container affects the new page

Although another CL[1] beat me to it, this would've also fixed the issue we
had navigating from a Settings sub-page to the About page, which used to jump
7.5px horizontally after a timeout due to us manipulating the scrollbar for
the animation.

[1] https://codereview.chromium.org/2379933003/

BUG=651616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-09-30 02:43:39]

michaelpg@chromium.org changed reviewers:
+ dbeam@chromium.org

[michaelpg, 2016-09-30 20:53:02]

PTAL.

[michaelpg, 2016-09-30 20:53:11]

Description was changed from

==========
MD Settings: Cancel unseen collapse animation

Don't play the collapse animation when hiding a page, because:

  1. The animation isn't visible, so it's extra work for nothing
  2. Messing with the container affects the new page

Although another CL[1] beat me to it, this would've also fixed the issue we
had navigating from a Settings sub-page to the About page, which used to jump
7.5px horizontally after a timeout due to us manipulating the scrollbar for
the animation.

[1] https://codereview.chromium.org/2379933003/

BUG=651616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Skip unseen collapse animation

Don't play the collapse animation when hiding a page, because:

  1. The animation isn't visible, so it's extra work for nothing
  2. Messing with the container affects the new page

Although another CL[1] beat me to it, this would've also fixed the issue we
had navigating from a Settings sub-page to the About page, which used to jump
7.5px horizontally after a timeout due to us manipulating the scrollbar for
the animation.

[1] https://codereview.chromium.org/2379933003/

BUG=651616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-09-30 21:40:39]

lgtm

[michaelpg, 2016-09-30 21:50:04]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2016-09-30 21:50:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 02:13:49]

Description was changed from

==========
MD Settings: Skip unseen collapse animation

Don't play the collapse animation when hiding a page, because:

  1. The animation isn't visible, so it's extra work for nothing
  2. Messing with the container affects the new page

Although another CL[1] beat me to it, this would've also fixed the issue we
had navigating from a Settings sub-page to the About page, which used to jump
7.5px horizontally after a timeout due to us manipulating the scrollbar for
the animation.

[1] https://codereview.chromium.org/2379933003/

BUG=651616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Skip unseen collapse animation

Don't play the collapse animation when hiding a page, because:

  1. The animation isn't visible, so it's extra work for nothing
  2. Messing with the container affects the new page

Although another CL[1] beat me to it, this would've also fixed the issue we
had navigating from a Settings sub-page to the About page, which used to jump
7.5px horizontally after a timeout due to us manipulating the scrollbar for
the animation.

[1] https://codereview.chromium.org/2379933003/

BUG=651616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-10-01 02:13:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-01 02:16:16]

Description was changed from

==========
MD Settings: Skip unseen collapse animation

Don't play the collapse animation when hiding a page, because:

  1. The animation isn't visible, so it's extra work for nothing
  2. Messing with the container affects the new page

Although another CL[1] beat me to it, this would've also fixed the issue we
had navigating from a Settings sub-page to the About page, which used to jump
7.5px horizontally after a timeout due to us manipulating the scrollbar for
the animation.

[1] https://codereview.chromium.org/2379933003/

BUG=651616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Skip unseen collapse animation

Don't play the collapse animation when hiding a page, because:

  1. The animation isn't visible, so it's extra work for nothing
  2. Messing with the container affects the new page

Although another CL[1] beat me to it, this would've also fixed the issue we
had navigating from a Settings sub-page to the About page, which used to jump
7.5px horizontally after a timeout due to us manipulating the scrollbar for
the animation.

[1] https://codereview.chromium.org/2379933003/

BUG=651616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/53c0cd015ae9b8d7cbf77a44aa8fb42f6ef568ec
Cr-Commit-Position: refs/heads/master@{#422285}
==========

[commit-bot: I haz the power, 2016-10-01 02:16:17]

Patchset 2 (id:??) landed as
https://crrev.com/53c0cd015ae9b8d7cbf77a44aa8fb42f6ef568ec
Cr-Commit-Position: refs/heads/master@{#422285}