Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js

Issue 2378933002: DevTools: fix scrolling in audits (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/audits/auditsPanel.css » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 }, 122 },
123 123
124 /** 124 /**
125 * @param {!Array.<!WebInspector.AuditCategoryResult>} categoryResults 125 * @param {!Array.<!WebInspector.AuditCategoryResult>} categoryResults
126 */ 126 */
127 showResults: function(categoryResults) 127 showResults: function(categoryResults)
128 { 128 {
129 if (!categoryResults._resultLocation) { 129 if (!categoryResults._resultLocation) {
130 categoryResults.sort((a, b) => (a.title || "").localeCompare(b.title || "")); 130 categoryResults.sort((a, b) => (a.title || "").localeCompare(b.title || ""));
131 var resultView = WebInspector.viewManager.createStackLocation(); 131 var resultView = WebInspector.viewManager.createStackLocation();
132 resultView.widget().element.classList.add("audit-result-view");
132 for (var i = 0; i < categoryResults.length; ++i) 133 for (var i = 0; i < categoryResults.length; ++i)
133 resultView.showView(new WebInspector.AuditCategoryResultPane(cat egoryResults[i])); 134 resultView.showView(new WebInspector.AuditCategoryResultPane(cat egoryResults[i]));
134 categoryResults._resultLocation = resultView; 135 categoryResults._resultLocation = resultView;
135 } 136 }
136 this.visibleView = categoryResults._resultLocation.widget(); 137 this.visibleView = categoryResults._resultLocation.widget();
137 }, 138 },
138 139
139 showLauncherView: function() 140 showLauncherView: function()
140 { 141 {
141 this.visibleView = this._launcherView; 142 this.visibleView = this._launcherView;
(...skipping 402 matching lines...) Expand 10 before | Expand all | Expand 10 after
544 } 545 }
545 546
546 // Contributed audit rules should go into this namespace. 547 // Contributed audit rules should go into this namespace.
547 WebInspector.AuditRules = {}; 548 WebInspector.AuditRules = {};
548 549
549 /** 550 /**
550 * Contributed audit categories should go into this namespace. 551 * Contributed audit categories should go into this namespace.
551 * @type {!Object.<string, function(new:WebInspector.AuditCategory)>} 552 * @type {!Object.<string, function(new:WebInspector.AuditCategory)>}
552 */ 553 */
553 WebInspector.AuditCategories = {}; 554 WebInspector.AuditCategories = {};
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/audits/auditsPanel.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698