Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2378933002: DevTools: fix scrolling in audits (Closed)

Created:
4 years, 2 months ago by luoe
Modified:
4 years, 2 months ago
Reviewers:
dgozman, lushnikov, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix scrolling in audits BUG=636230 Committed: https://crrev.com/7dffb9dd412ed8fc5f7db26a432fdbaa7f8e1c28 Cr-Commit-Position: refs/heads/master@{#421848}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits/auditsPanel.css View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
luoe
It looks like we applied the same fix to SourcesPanel when SimpleViews were changed, but ...
4 years, 2 months ago (2016-09-28 23:52:12 UTC) #2
luoe
4 years, 2 months ago (2016-09-29 01:08:14 UTC) #4
luoe
4 years, 2 months ago (2016-09-29 01:10:39 UTC) #6
dgozman
lgtm
4 years, 2 months ago (2016-09-29 03:54:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378933002/1
4 years, 2 months ago (2016-09-29 16:46:14 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 16:52:51 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 16:55:28 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7dffb9dd412ed8fc5f7db26a432fdbaa7f8e1c28
Cr-Commit-Position: refs/heads/master@{#421848}

Powered by Google App Engine
This is Rietveld 408576698