Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2378923003: html_inline.py ignores <include> directive in external stylesheets. It replaces src with base64 val… (Closed)

Created:
4 years, 2 months ago by flackr
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

html_inline.py ignores <include> directive in external stylesheets. It replaces src with base64 value in externals but when when src attr belongs to include directive, final output has include directive.This commit recheck inline css that can have include directive. BUG=634704 Review-Url: https://codereview.chromium.org/2249493002 Cr-Commit-Position: refs/heads/master@{#416470} (cherry picked from commit f0f1f24c00093e0112f7c7956fb07518fc49aa29) Committed: https://chromium.googlesource.com/chromium/src/+/420a1094ce45529b450532eaf916f6a33e595eae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -5 lines) Patch
M tools/grit/grit/format/html_inline.py View 2 chunks +16 lines, -5 lines 0 comments Download
M tools/grit/grit/format/html_inline_unittest.py View 1 chunk +89 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
flackr
4 years, 2 months ago (2016-09-29 14:38:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
420a1094ce45529b450532eaf916f6a33e595eae.

Powered by Google App Engine
This is Rietveld 408576698