Adds ability to suspend notifying observers when display list is changed

ui/display/display_list_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/display/display_list.h"
 
 #include <string>
 #include <vector>
 
 #include "base/strings/string_number_conversions.h"
@@ skipping 91 matching lines @@
   EXPECT_EQ("Changed id=3 primary", observer.GetAndClearChanges());
   EXPECT_EQ(3, display_list.GetPrimaryDisplayIterator()->id());
 
   // Delete the first.
   display_list.RemoveDisplay(2);
   ASSERT_EQ(1u, display_list.displays().size());
   EXPECT_EQ("Removed id=2", observer.GetAndClearChanges());
   EXPECT_EQ(3, display_list.GetPrimaryDisplayIterator()->id());
 }
 
+TEST(DisplayListTest, SuspendUpdates) {
+  DisplayList display_list;
+  display_list.AddDisplay(display::Display(2, gfx::Rect(0, 0, 801, 802)),
+                          DisplayList::Type::PRIMARY);
+
+  DisplayObserverImpl observer;
+  display_list.AddObserver(&observer);
+  {
+    // Suspend updates and add a new display.
+    std::unique_ptr<DisplayListObserverLock> lock =
+        display_list.SuspendObserverUpdates();
+    display_list.AddDisplay(display::Display(3, gfx::Rect(0, 0, 809, 802)),
+                            DisplayList::Type::NOT_PRIMARY);
+    EXPECT_EQ(2u, display_list.displays().size());
+    // No update should have been generated.
+    EXPECT_TRUE(observer.GetAndClearChanges().empty());
+  }
+  // The lock has been destroyed and should now notify observers.
+  EXPECT_EQ("Added id=3", observer.GetAndClearChanges());
+
+  // Two locks with an add followed by an update.
+  {
+    std::unique_ptr<DisplayListObserverLock> lock1 =
+        display_list.SuspendObserverUpdates();
+    {
+      std::unique_ptr<DisplayListObserverLock> lock2 =
+          display_list.SuspendObserverUpdates();
+      display_list.AddDisplay(display::Display(4, gfx::Rect(0, 0, 809, 802)),
+                              DisplayList::Type::NOT_PRIMARY);
+      EXPECT_TRUE(observer.GetAndClearChanges().empty());
+      EXPECT_EQ(3u, display_list.displays().size());
+    }
+    // No updates should have been generated as there is still a valid lock.
+    EXPECT_TRUE(observer.GetAndClearChanges().empty());
+
+    // Update the display. Lock still held, so no updates.
+    display::Display updated_display = display_list.displays()[2];
+    updated_display.set_bounds(gfx::Rect(0, 0, 803, 802));
+    display_list.UpdateDisplay(updated_display, DisplayList::Type::NOT_PRIMARY);
+    EXPECT_TRUE(observer.GetAndClearChanges().empty());
+  }
+  // All locks have been destroyed, so observer should be called.
+  EXPECT_EQ("Added id=4", observer.GetAndClearChanges());
+}
+
 }  // namespace
 }  // namespace display