Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2378903004: MD History: Move the card sizing CSS to apply to the iron-list (Closed)

Created:
4 years, 2 months ago by tsergeant
Modified:
4 years, 2 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Move the card sizing CSS to apply to the iron-list This fixes an issue where it was possible to click on the margins of the list to select items. These margins are now part of the list itself, and individual items only occupy the exact horizontal space they need. This change should have no visual impact on the layout of the list. BUG=651556 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/af77c9922af8486fc555b268a0eaeeb8d6055c57 Cr-Commit-Position: refs/heads/master@{#422043}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove unused CSS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -90 lines) Patch
M chrome/browser/resources/md_history/app.crisper.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 1 3 chunks +32 lines, -38 lines 0 comments Download
M chrome/browser/resources/md_history/history_item.html View 2 chunks +42 lines, -48 lines 0 comments Download
M chrome/browser/resources/md_history/history_item.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/history_list.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_history/lazy_load.vulcanized.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
tsergeant
https://codereview.chromium.org/2378903004/diff/1/chrome/browser/resources/md_history/history_item.js File chrome/browser/resources/md_history/history_item.js (right): https://codereview.chromium.org/2378903004/diff/1/chrome/browser/resources/md_history/history_item.js#newcode127 chrome/browser/resources/md_history/history_item.js:127: this.$['main-container'], null, new FocusRowDelegate(this)); I don't think there's any ...
4 years, 2 months ago (2016-09-30 04:47:58 UTC) #3
calamity
lgtm https://codereview.chromium.org/2378903004/diff/1/chrome/browser/resources/md_history/history_item.js File chrome/browser/resources/md_history/history_item.js (right): https://codereview.chromium.org/2378903004/diff/1/chrome/browser/resources/md_history/history_item.js#newcode127 chrome/browser/resources/md_history/history_item.js:127: this.$['main-container'], null, new FocusRowDelegate(this)); On 2016/09/30 04:47:58, tsergeant ...
4 years, 2 months ago (2016-09-30 04:58:45 UTC) #4
tsergeant
https://codereview.chromium.org/2378903004/diff/1/chrome/browser/resources/md_history/history_list.html File chrome/browser/resources/md_history/history_list.html (right): https://codereview.chromium.org/2378903004/diff/1/chrome/browser/resources/md_history/history_list.html#newcode25 chrome/browser/resources/md_history/history_list.html:25: } On 2016/09/30 04:58:45, calamity wrote: > This can ...
4 years, 2 months ago (2016-09-30 05:11:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378903004/20001
4 years, 2 months ago (2016-09-30 05:11:45 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-30 06:29:11 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 06:31:26 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/af77c9922af8486fc555b268a0eaeeb8d6055c57
Cr-Commit-Position: refs/heads/master@{#422043}

Powered by Google App Engine
This is Rietveld 408576698