Annotation protobuf code can now dump final.

Annotation protobuf code can now dump final.

Add an operational flag to allow the LogDog annotation protobuf code to
dump the final protobuf at termination.

BUG=chromium:
TEST=None

Committed: https://github.com/luci/recipes-py/commit/2e9ed981d6e2f75889aef93cb2b6a5e50a8aac37

[dnj, 2016-09-28 22:58:31]

dnj@chromium.org changed reviewers:
+ nodir@chromium.org

[dnj, 2016-09-28 22:58:31]

PTAL

[nodir, 2016-09-28 23:02:22]

lgtm

https://codereview.chromium.org/2378903002/diff/1/recipe_engine/stream_logdog.py
File recipe_engine/stream_logdog.py (right):

https://codereview.chromium.org/2378903002/diff/1/recipe_engine/stream_logdog...
recipe_engine/stream_logdog.py:379: with open(self._dump_path, 'wb') as fd:
please swap these two lines, so in the worst case we have an empty file (which
is still a valid protobuf)

[dnj, 2016-09-28 23:04:11]

https://codereview.chromium.org/2378903002/diff/1/recipe_engine/stream_logdog.py
File recipe_engine/stream_logdog.py (right):

https://codereview.chromium.org/2378903002/diff/1/recipe_engine/stream_logdog...
recipe_engine/stream_logdog.py:379: with open(self._dump_path, 'wb') as fd:
On 2016/09/28 23:02:22, nodir wrote:
> please swap these two lines, so in the worst case we have an empty file (which
> is still a valid protobuf)

Done.

[dnj, 2016-10-12 22:32:53]

The CQ bit was checked by dnj@chromium.org

[dnj, 2016-10-12 22:32:53]

The patchset sent to the CQ was uploaded after l-g-t-m from nodir@chromium.org
Link to the patchset: https://codereview.chromium.org/2378903002/#ps40001
(title: "Rebase, add unit test.")

[commit-bot: I haz the power, 2016-10-12 22:33:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 22:38:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 22:38:31]

Try jobs failed on following builders:
  Recipes-py Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/31d3db2264649510)

[dnj, 2016-10-12 22:41:54]

dnj@chromium.org changed reviewers:
+ iannucci@chromium.org, martiniss@chromium.org

[dnj, 2016-10-12 22:41:55]

PTAL

[martiniss, 2016-10-12 23:01:25]

lgtm

This is useful for kitchen, I assume?

https://codereview.chromium.org/2378903002/diff/40001/recipe_engine/stream_lo...
File recipe_engine/stream_logdog.py (right):

https://codereview.chromium.org/2378903002/diff/40001/recipe_engine/stream_lo...
recipe_engine/stream_logdog.py:594: return self._last_flush_data
this is the data we last flushed. We always flush the whole annotation data?

[dnj, 2016-10-12 23:15:03]

https://codereview.chromium.org/2378903002/diff/40001/recipe_engine/stream_lo...
File recipe_engine/stream_logdog.py (right):

https://codereview.chromium.org/2378903002/diff/40001/recipe_engine/stream_lo...
recipe_engine/stream_logdog.py:594: return self._last_flush_data
On 2016/10/12 23:01:25, martiniss wrote:
> this is the data we last flushed. We always flush the whole annotation data?

Yep.

[dnj, 2016-10-12 23:15:06]

The CQ bit was checked by dnj@chromium.org

[commit-bot: I haz the power, 2016-10-12 23:15:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 23:18:14]

Description was changed from

==========
Annotation protobuf code can now dump final.

Add an operational flag to allow the LogDog annotation protobuf code to
dump the final protobuf at termination.

BUG=chromium:
TEST=None
==========

to

==========
Annotation protobuf code can now dump final.

Add an operational flag to allow the LogDog annotation protobuf code to
dump the final protobuf at termination.

BUG=chromium:
TEST=None

Committed:
https://github.com/luci/recipes-py/commit/2e9ed981d6e2f75889aef93cb2b6a5e50a8...
==========

[commit-bot: I haz the power, 2016-10-12 23:18:15]

Committed patchset #3 (id:40001) as
https://github.com/luci/recipes-py/commit/2e9ed981d6e2f75889aef93cb2b6a5e50a8...