Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2378883002: mus ws: Consistently use mojom::Cursor instead of int32_t. (Closed)

Created:
4 years, 2 months ago by Elliot Glaysher
Modified:
4 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus ws: Consistently use mojom::Cursor instead of int32_t. Instead of casting back and forth between the two types at different layers of the window server, consistently use mojom::Cursor and only cast to int32_t at the final usage in DefaultPlatformDisplay. BUG=614037 Committed: https://crrev.com/2fb80909a5e274f92122ba067bdf10cc4483417b Cr-Commit-Position: refs/heads/master@{#421856}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -79 lines) Patch
M services/ui/ws/cursor_unittest.cc View 3 chunks +20 lines, -25 lines 0 comments Download
M services/ui/ws/display.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/ws/display.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M services/ui/ws/drag_controller.h View 4 chunks +4 lines, -3 lines 0 comments Download
M services/ui/ws/drag_controller.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M services/ui/ws/event_dispatcher.h View 2 chunks +2 lines, -1 line 0 comments Download
M services/ui/ws/event_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/platform_display.h View 3 chunks +3 lines, -2 lines 0 comments Download
M services/ui/ws/platform_display.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/ws/server_window.h View 1 chunk +3 lines, -3 lines 0 comments Download
M services/ui/ws/server_window.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/ws/server_window_observer.h View 2 chunks +3 lines, -2 lines 0 comments Download
M services/ui/ws/test_utils.h View 4 chunks +5 lines, -5 lines 0 comments Download
M services/ui/ws/test_utils.cc View 7 chunks +12 lines, -8 lines 0 comments Download
M services/ui/ws/window_manager_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/window_server.h View 2 chunks +3 lines, -3 lines 0 comments Download
M services/ui/ws/window_server.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M services/ui/ws/window_tree.h View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/window_tree.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M services/ui/ws/window_tree_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
Elliot Glaysher
Removes the back and forth casting of cursors at different layers.
4 years, 2 months ago (2016-09-28 21:33:15 UTC) #4
sky
Nice! Thanks for the cleanup. LGTM
4 years, 2 months ago (2016-09-29 02:45:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378883002/1
4 years, 2 months ago (2016-09-29 17:07:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 17:14:12 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 17:16:10 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2fb80909a5e274f92122ba067bdf10cc4483417b
Cr-Commit-Position: refs/heads/master@{#421856}

Powered by Google App Engine
This is Rietveld 408576698