Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2378853002: Fix crash when clicking BROWSE THE PHYSICAL WEB (Closed)

Created:
4 years, 2 months ago by hayesjordan
Modified:
4 years, 2 months ago
Reviewers:
cco3, gone
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash when clicking BROWSE THE PHYSICAL WEB When the enable-physical-web flag is enabled but the setting under settings->privacy->physical web is off, the user can cause chrome to crash by going to chrome://physical-web and clicking the "BROWSE THE PHYSICAL WEB" button. BUG=651076 Committed: https://crrev.com/d67018f2cc74b4763205465fff5dc4ac31ab9103 Cr-Commit-Position: refs/heads/master@{#421635}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
hayesjordan
4 years, 2 months ago (2016-09-28 19:27:52 UTC) #3
cco3
LGTM
4 years, 2 months ago (2016-09-28 19:32:23 UTC) #5
gone
lgtm
4 years, 2 months ago (2016-09-28 20:07:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378853002/1
4 years, 2 months ago (2016-09-28 20:09:12 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 20:46:43 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 20:49:30 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d67018f2cc74b4763205465fff5dc4ac31ab9103
Cr-Commit-Position: refs/heads/master@{#421635}

Powered by Google App Engine
This is Rietveld 408576698