Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js

Issue 2378843003: Timeline: fix screenshots for headless shell (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js
index 725e0e4752c501ea7c3f5a7f934c826d98d7837e..ea340b13c685c20c3ee4574a3c9f8a2be5986968 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js
@@ -117,6 +117,35 @@ WebInspector.TracingModel._extractId = function(payload)
}
/**
+ * @param {!WebInspector.TracingModel} tracingModel
+ * @return {?WebInspector.TracingModel.Thread}
+ *
+ * FIXME: this is here just for convenience of re-use between modules.
alph 2016/09/29 00:12:53 TODO
+ * This really belongs to a higher level, since it is specific to chrome's
+ * usage of tracing.
+ */
+WebInspector.TracingModel.browserMainThread = function(tracingModel)
+{
+ var processes = tracingModel.sortedProcesses();
+ var browserProcess = [];
alph 2016/09/29 00:12:53 nit: browserProcesses
+ var crRendererMainThreads = [];
+ for (var process of processes) {
+ if (process.name().toLowerCase().endsWith("Browser"))
alph 2016/09/29 00:12:53 browser
+ browserProcess.push(process);
+ crRendererMainThreads.push(...process.sortedThreads().filter(t => t.name() === "CrBrowserMain"));
+ }
+ if (crRendererMainThreads.length === 1)
+ return crRendererMainThreads[0];
+ if (browserProcess.length === 1)
+ return browserProcess[0].threadByName("CrBrowserMain");
+ var tracingStartedInBrowser = tracingModel.devToolsMetadataEvents().filter(e => e.name === "TracingStartedInBrowser");
+ if (tracingStartedInBrowser.length === 1)
+ return tracingStartedInBrowser[0].thread;
+ WebInspector.console.error("Failed to find browser main thread in trace, some timeline features may be unavailable");
+ return null;
+}
+
+/**
* @interface
*/
WebInspector.BackingStorage = function()

Powered by Google App Engine
This is Rietveld 408576698