Output svg foreign object paint offset in paint properties

Output svg foreign object paint offset in paint properties

This fixes svg foreign object layout tests in slimmngPaintInvalidation
mode.

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/71436559155dd9bd562431dbfb0d2104e0d0c9a1
Cr-Commit-Position: refs/heads/master@{#421744}

[Xianzhu, 2016-09-28 19:21:02]

Description was changed from

==========
Remove special case for svg foreign object transform in property tree

This makes all svg foriegn object layout tests pass in
slimmingPaintInvalidation mode.

BUG=646176
==========

to

==========
Remove special case for svg foreign object transform in property tree

This makes all svg foriegn object layout tests pass in
slimmingPaintInvalidation mode.

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-09-28 19:21:19]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 19:21:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 19:52:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 19:52:49]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[Xianzhu, 2016-09-28 21:46:03]

Description was changed from

==========
Remove special case for svg foreign object transform in property tree

This makes all svg foriegn object layout tests pass in
slimmingPaintInvalidation mode.

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Output svg foreign object paint offset in paint properties

This fixes svg foreign object layout tests in slimmngPaintInvalidation
mode.

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-09-28 21:46:09]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 21:46:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-09-28 21:55:16]

Description was changed from

==========
Output svg foreign object paint offset in paint properties

This fixes svg foreign object layout tests in slimmngPaintInvalidation
mode.

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Output svg foreign object paint offset in paint properties

This fixes svg foreign object layout tests in slimmngPaintInvalidation
mode.

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-09-28 22:21:57]

wangxianzhu@chromium.org changed reviewers:
+ pdr@chromium.org

[commit-bot: I haz the power, 2016-09-28 23:19:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 23:19:21]

Dry run: This issue passed the CQ dry run.

[pdr., 2016-09-29 01:26:34]

LGTM

https://codereview.chromium.org/2378833002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp (right):

https://codereview.chromium.org/2378833002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp:221: // SVG
(other than SVGForeign object) does not use paint offset internally.
I think LayoutSVGText uses this too (the comment in
LayoutSVGForeignObject::layout alerted me to this). No need to fix that now, but
can you add "TODO(wangxianzhu): Investigate whether LayoutSVGText should use
paint offset too."

Nit: "SVG (other than SVGForeignObject) does not use paint offset internally."

[Xianzhu, 2016-09-29 01:32:47]

https://codereview.chromium.org/2378833002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp (right):

https://codereview.chromium.org/2378833002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp:221: // SVG
(other than SVGForeign object) does not use paint offset internally.
On 2016/09/29 01:26:34, pdr. wrote:
> I think LayoutSVGText uses this too (the comment in
> LayoutSVGForeignObject::layout alerted me to this). No need to fix that now,
but
> can you add "TODO(wangxianzhu): Investigate whether LayoutSVGText should use
> paint offset too."
> 
> Nit: "SVG (other than SVGForeignObject) does not use paint offset internally."

Done.

[Xianzhu, 2016-09-29 01:32:50]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-09-29 01:32:51]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2378833002/#ps40001
(title: "-")

[commit-bot: I haz the power, 2016-09-29 01:33:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-09-29 01:34:32]

The CQ bit was unchecked by wangxianzhu@chromium.org

[Xianzhu, 2016-09-29 02:52:53]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-09-29 02:52:53]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2378833002/#ps60001
(title: "-")

[commit-bot: I haz the power, 2016-09-29 02:53:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-09-29 02:57:40]

https://codereview.chromium.org/2378833002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp (right):

https://codereview.chromium.org/2378833002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp:221: // SVG
(other than SVGForeign object) does not use paint offset internally.
On 2016/09/29 01:26:34, pdr. wrote:
> I think LayoutSVGText uses this too (the comment in
> LayoutSVGForeignObject::layout alerted me to this). No need to fix that now,
but
> can you add "TODO(wangxianzhu): Investigate whether LayoutSVGText should use
> paint offset too."
> 

Just looked into LayoutSVGText and found that it's different from
LayoutSVGForeignObject. LayoutSVGText's offset is fully implemented in SVG
hierarchy, while LayoutSVGForeignObject's viewport offset is baked into its
LayoutBox::location(). This seems the reason that we must exclude
LayoutSVGForeignObject's viewport offset from its transform. Perhaps we can
change that to make all non-root SVG objects behave in the same way about
transforms and paint offsets. The FIXME at line 227 below should cover this.

[commit-bot: I haz the power, 2016-09-29 04:13:07]

Description was changed from

==========
Output svg foreign object paint offset in paint properties

This fixes svg foreign object layout tests in slimmngPaintInvalidation
mode.

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Output svg foreign object paint offset in paint properties

This fixes svg foreign object layout tests in slimmngPaintInvalidation
mode.

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2016-09-29 04:13:08]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-29 04:15:39]

Description was changed from

==========
Output svg foreign object paint offset in paint properties

This fixes svg foreign object layout tests in slimmngPaintInvalidation
mode.

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Output svg foreign object paint offset in paint properties

This fixes svg foreign object layout tests in slimmngPaintInvalidation
mode.

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/71436559155dd9bd562431dbfb0d2104e0d0c9a1
Cr-Commit-Position: refs/heads/master@{#421744}
==========

[commit-bot: I haz the power, 2016-09-29 04:15:40]

Patchset 4 (id:??) landed as
https://crrev.com/71436559155dd9bd562431dbfb0d2104e0d0c9a1
Cr-Commit-Position: refs/heads/master@{#421744}