Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2290)

Unified Diff: chrome/test/data/webui/settings/settings_main_search_test.js

Issue 2378823004: Timing issues in tests for settings-main scrolling/overscroll. (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/settings_main_search_test.js
diff --git a/chrome/test/data/webui/settings/settings_main_test.js b/chrome/test/data/webui/settings/settings_main_search_test.js
similarity index 87%
rename from chrome/test/data/webui/settings/settings_main_test.js
rename to chrome/test/data/webui/settings/settings_main_search_test.js
index e4af140ca7e78b8623cdce4d7a7150d961294335..46f6b83c4a552a95604f060bc32fec21c3f9b88f 100644
--- a/chrome/test/data/webui/settings/settings_main_test.js
+++ b/chrome/test/data/webui/settings/settings_main_search_test.js
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-cr.define('settings_main_page', function() {
+cr.define('settings_main_search_test', function() {
/**
* @implements {SearchManager}
*/
@@ -42,7 +42,7 @@ cr.define('settings_main_page', function() {
return CrSettingsPrefs.initialized;
});
- suite('MainPageTests', function() {
+ suite('settings-main search', function() {
/** @type {?TestSearchManager} */
var searchManager = null;
@@ -168,32 +168,6 @@ cr.define('settings_main_page', function() {
'', settingsMain.$$('settings-advanced-page').style.display);
});
});
-
- test('can collapse advanced on advanced section route', function() {
- settings.navigateTo(settings.Route.PRIVACY);
- Polymer.dom.flush();
-
- var advancedToggle = settingsMain.$$('#advancedToggle');
- assertTrue(!!advancedToggle);
-
- MockInteractions.tap(advancedToggle);
- Polymer.dom.flush();
-
- assertFalse(settingsMain.showPages_.advanced);
- });
-
- test('navigating to a basic page does not collapse advanced', function() {
- settings.navigateTo(settings.Route.PRIVACY);
- Polymer.dom.flush();
-
- var advancedToggle = settingsMain.$$('#advancedToggle');
- assertTrue(!!advancedToggle);
-
- settings.navigateTo(settings.Route.PEOPLE);
- Polymer.dom.flush();
-
- assertTrue(settingsMain.showPages_.advanced);
- });
});
}

Powered by Google App Engine
This is Rietveld 408576698