Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2378813002: Use a larger sleep time in get_allocation_profile_rpc_test so that the test doesn't flake on Windows (Closed)

Created:
4 years, 2 months ago by Cutch
Modified:
4 years, 2 months ago
Reviewers:
rmacnak, kustermann
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use a larger sleep time in get_allocation_profile_rpc_test so that the test doesn't flake on Windows Fixes #27444 BUG= R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/1b5533fe8f0a34d0645a5a97ce22143bca0037d6

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/observatory/tests/service/get_allocation_profile_rpc_test.dart View 2 chunks +2 lines, -2 lines 1 comment Download

Messages

Total messages: 6 (3 generated)
Cutch
4 years, 2 months ago (2016-09-28 18:22:04 UTC) #3
kustermann
lgtm https://codereview.chromium.org/2378813002/diff/1/runtime/observatory/tests/service/get_allocation_profile_rpc_test.dart File runtime/observatory/tests/service/get_allocation_profile_rpc_test.dart (right): https://codereview.chromium.org/2378813002/diff/1/runtime/observatory/tests/service/get_allocation_profile_rpc_test.dart#newcode16 runtime/observatory/tests/service/get_allocation_profile_rpc_test.dart:16: return completer.future; Side note: This could be just: ...
4 years, 2 months ago (2016-09-28 18:26:24 UTC) #4
Cutch
4 years, 2 months ago (2016-09-28 19:45:12 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
1b5533fe8f0a34d0645a5a97ce22143bca0037d6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698